core icon indicating copy to clipboard operation
core copied to clipboard

Bump PySwitchbee to 1.7.21

Open jafar-atili opened this issue 1 year ago • 3 comments

Breaking change

Proposed change

https://github.com/jafar-atili/pySwitchbee/releases/tag/1.7.21

Replacing a physical broken Central Unit forces configuring the entities from scratch, even if we restore the old Central Unit backup to the new one. this is frustrating. SwitchBee have integrated a new Unique ID cuCode (which is a combination of random number and the Central Unit MAC) the cuCode will be generated on new configuration of the Central Unit and will be saved and moved with the Backups.

This means, if my current Central Unit physically breaks, replacing it with new Central Unit and restoring the backup won't break the integration in Home Assistant.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jafar-atili avatar May 01 '23 22:05 jafar-atili

Hi @therealjafar

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar May 01 '23 22:05 home-assistant[bot]

Hi @therealjafar

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar May 02 '23 06:05 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 02 '23 06:05 home-assistant[bot]

Hi @therealjafar

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar May 05 '23 09:05 home-assistant[bot]

Hi @therealjafar

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar May 05 '23 10:05 home-assistant[bot]

Please sign the CLA.

Additionally, our config flows require a 100% test coverage. This PR makes it drop below that threshold. Could you take a look?

Thanks! 👍

../Frenck

Done

jafar-atili avatar May 07 '23 10:05 jafar-atili