core icon indicating copy to clipboard operation
core copied to clipboard

Add new freebox platforms

Open nachonam opened this issue 1 year ago • 4 comments

Breaking change

Proposed change

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/27194

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Black (black --fast homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [X] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [X] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [X] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [X] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

nachonam avatar Apr 28 '23 16:04 nachonam

Hey there @hacf-fr, @quentame, mind taking a look at this pull request as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign freebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Apr 28 '23 16:04 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 24 '23 10:05 home-assistant[bot]

Alarm and shutter devices will be added in separated PR

nachonam avatar May 28 '23 05:05 nachonam

Hi, Thank Nachonam for this integration ! I'm using your full integration (before removing alarm/shutter) and it's great!

Would it be possible to add controls on devices like this integration?

image

Source : https://github.com/echauvet/freebox_home

HpNoTiQ56 avatar Jun 05 '23 07:06 HpNoTiQ56

can't wait for this ! thanks for your work guys !!!

Keltharak avatar Jun 13 '23 12:06 Keltharak

🥳

Keltharak avatar Jun 26 '23 21:06 Keltharak

Actually working on this PR Python 11 migration

nachonam avatar Jul 24 '23 20:07 nachonam

Please split this PR into several PRs, where each adds/improves one thing. The type of change of this PR requires at least ticking "new feature", "code quality improvements" and maybe also "bugfix" (error handling in switch). Ticking more than one checkbox is a good sign to split PRs.

This PR can be at least split into these PRs:

  • One PR for adding the binary sensor platform.
  • One to handle the exceptions in switch.py
  • One to add the new FreeboxBatterySensor in sensor.py
  • One for refactoring the Freeboxlabel

Smaller PRs can be reviewed quicker and will therefore be merged quicker :)

Just created 2 PRs to split this PR a little:

  • ❌ should be reverted --> One to handle the exceptions in switch.py
  • #99222 --> One to add the new FreeboxBatterySensor in sensor.py
  • #99224 --> One for refactoring the Freeboxlabel

@nachonam : don't hesitate to review & test

Quentame avatar Aug 28 '23 16:08 Quentame

#99222 & #99224 are now merged and this branch has been updated by handling conflicts and fix few comments.

You are almost done, by applying comments in current PR & from #99222 but to binary_sensor ☺️

Quentame avatar Aug 29 '23 11:08 Quentame

Sent you a Discord PM

Quentame avatar Sep 14 '23 11:09 Quentame

router.py comments are not addressed

Roolback in http error exceptions done. Only keep 2 exception: HttpRequestError for raid sensors (from another PR) InssufficentPermissionError to check Freebox permission (was HttpRequestError in previous version)

nachonam avatar Sep 18 '23 06:09 nachonam