core icon indicating copy to clipboard operation
core copied to clipboard

Add 'Last update' timestamp attributes for timed HomeWizard sensors

Open DCSBL opened this issue 1 year ago • 1 comments

Proposed change

Add 'Last update' attributes for gas and peak demand.

  • Gas updates once every hour or 5 minutes, the exact timestamp is available. Users can use the build-in 'Last changed/updated', but it won't change if you don't use gas.
  • Peak demand current month shows the highest usage of this month. We got some request to show the real timestamp instead 'Last changed'. I think it is useful for new installations.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

DCSBL avatar Apr 21 '23 20:04 DCSBL

Preference would be that these are their own sensors instead of attributes. Also perhaps not enabled by default.

gjohansson-ST avatar Apr 21 '23 20:04 gjohansson-ST

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 03 '23 11:05 home-assistant[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 01 '23 14:08 github-actions[bot]