Add support for Ring Intercom

[MartinPham]

Breaking change

Proposed change

The current Ring intergration is not supporting Ring Intercom devices (https://it-it.ring.com/products/intercom), as described here https://github.com/home-assistant/core/issues/82565. I've added support for it, introducing new sensors, and button to open door

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [x] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #82565
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Black (black --fast homeassistant tests)
• [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [x] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hi @MartinPham

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[MartinPham]

Documentation PR submitted https://github.com/home-assistant/home-assistant.io/pull/27050, thanks

[spanzetta]

Why it is not yet releasing?

[asphalter]

Why it is not yet releasing?

Missing approval. Hoping for someone of the team to keep in charge of this.

[JoernBerkefeld]

push

[cioppz]

Can someone else add the missing docs. Additionally, if u tell me what they should contain, i can try adding them by myself🙏🏼

[cubic3d]

Can someone else add the missing docs. Additionally, if u tell me what they should contain, i can try adding them by myself🙏🏼

There is no missing documentation, PR is in #27050 as stated above in the comment.

[asphalter]

Can someone else add the missing docs. Additionally, if u tell me what they should contain, i can try adding them by myself🙏🏼

There is no missing documentation, PR is in #27050 as stated above in the comment.

Thanks cubic3d, what is actually blocking the merge then?

[realealessio]

Following this old page, https://github.com/home-assistant/probot-home-assistant/issues/17 , the link to the documentation is missing in the PR description.. can someone add it?

[StasonJatham]

I can't figure out how to edit the original PR comment. This is an easy fix as @MartinPham has already written the documentation. This can be fixed by replacing the empty Link to documentation with:

Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/27050

It should then pass the test for merge.

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[asphalter]

@MartinPham is up to you. Could you please review che proposed changes and use the 'Ready for review' button once done?

[IdWebNicola]

@emontnemery Can you provide your review of the changes? Thank 👍

[cioppz]

@emontnemery Can you provide your review of the changes? Thank 👍

It’s funny how actively us, speaking about the Italian HA users, are pushing for this changes to be merged 🤣

[asphalter]

@emontnemery Can you provide your review of the changes? Thank 👍

It’s funny how actively us, speaking about the Italian HA users, are pushing for this changes to be merged 🤣

To be honest, it's a (simple and quite small sized, non impacting) change proposed on April and it's now June. Frankly it's time to merge.

[anongeek]

I would be interested as well for this device support. Thanks.

[jomatotu]

+1 also interested in this 🙏

[asphalter]

Any news on this @emontnemery ?

[matthiaslexer]

+1

[rpetteruti]

+1

[developerGM]

Hi guys, any news?

[pattyland]

Can this abuse of the pull request conversation for unnecessary comments please stop? Use Discord or something for that

[frenck]

Thanks for reporting the spam/abuse above pattyland. I've hidden all unrelated comments. Let's please keep it on topic (actual code review) and move other discussions/questions or +1's into the forums and chat.

Also, to everyone, please don't ping people to demand attention. While you might mean well, it often comes across as demanding, resulting in the opposite effect.

../Frenck

[frenck]

I've marked this PR, as changes are requested that need to be processed. Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

[frenck]

@MartinPham As per previous comment, there are un-addressed review comments, yet you have marked the PR ready for review? I'm confused about your action at this point.

I'm going to mark this PR as draft again. Please address the above review comments by @emontnemery before you undraft it.

Thanks 👍

../Frenck

[tispokes]

@MartinPham please 😁

[HpNoTiQ56]

Hi, Don't know why but my ring intercom isn't shown! I've used Custom_components_PR and got all confirmation. My acc is connected but my intercom doesn't appear.

[kevin-kraus]

Hi,

Don't know why but my ring intercom isn't shown!

I've used Custom_components_PR and got all confirmation. My acc is connected but my intercom doesn't appear.

I can confirm aswell, I‘ve checked out the PR branch and connected my Ring account to the running instance and my intercom wasn’t shown too.

After digging and debugging a little bit deeper I’ve found out that the used python library does not yet support the intercom as it is not returned under devices.

I don’t know if this maybe depends on the users location as the PR author is probably from Italy and also using an Italian account.

Maybe someone can confirm that it is working for him/her?

[MartinPham]

Sorry guys... currently I'm pretty full of tasks on my daily job, I will try to have time for the comments!

[developerGM]

@MartinPham thanks for your work and I hope that we can use this integration directly in hassio core.

I am testing your custom component and I noted that can be really important have a switch to turn on/off the call/notification on phone when someone ring (how can I do inside Ring app mobile) This can be really important creating an automation on homeassistant that turn_off notification during the night.