core icon indicating copy to clipboard operation
core copied to clipboard

Add Flexit bacnet integration

Open piotrbulinski opened this issue 2 years ago • 7 comments

Proposed change

New integration for Flexit Nordic air handling units using built-in BACnet support. Existing 'flexit' integration requires an additional Modbus adapter installed, so this is simpler and cheaper to use.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/26670

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

piotrbulinski avatar Mar 20 '23 21:03 piotrbulinski

I have successfully tested this PR locally with my Flexit Nordic S4.

Screenshot 2023-03-21 at 09 13 12 (we should add the flexit logo here, but it's a different repo)

Screenshot 2023-03-21 at 09 15 05 Screenshot 2023-03-21 at 09 15 19

Great work Piotr!

lellky avatar Mar 21 '23 08:03 lellky

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Mar 21 '23 13:03 home-assistant[bot]

@Lash-L @frenck thanks for the valuable feedback! I tried to address most of it today, but still need to work on the tests and type hints support, but that's probably later this week.

piotrbulinski avatar Mar 21 '23 21:03 piotrbulinski

What's the status here? Do you need any help? Would be awesome to get this merged! 🚀

lellky avatar Apr 05 '23 09:04 lellky

Hi guys!

I'm eager to get this feature in my Home Assistant as I have one of those Flexit units.

There seems to be so little left to do here to get it merged. @piotrbulinski have you looked at the suggestions by @frenck ? I would really like to help, but I don't really understand the request for change made.

Cheers,

Lellky

lellky avatar May 16 '23 09:05 lellky

@lellky I believe I addressed all of the feedback from @frenck and @Lash-L, so now it's back for another round of reviews.

piotrbulinski avatar May 16 '23 09:05 piotrbulinski

Any estimates for when this will be merged? Really looking forward to it

AlfHou avatar Jun 05 '23 14:06 AlfHou

I replaced Home Assistant in my house with another solution, so won't be available to work on this PR/feature any more.

Feel free to fork code from my GitHub and pursue the journey of adding it to HA, just make sure to remove me as code owner from the manifest.

piotrbulinski avatar Jun 12 '23 19:06 piotrbulinski

Thank you for your efforts. What did you replace it with?

AlfHou avatar Jun 12 '23 20:06 AlfHou

😭

lellky avatar Jun 13 '23 06:06 lellky

@AlfHou I'm using the new Homey Pro - my plan is to implement the Flexit Nordic integration in there.

piotrbulinski avatar Jun 13 '23 07:06 piotrbulinski

@AlfHou I'm using the new Homey Pro - my plan is to implement the Flexit Nordic integration in there.

This is really sad for Home Assistant, and for it's users 😢 . I really hope that we can learn something from this.

@piotrbulinski good luck with Homey Pro and thank you for your contribution (and especially for your BACnet library, I use it everyday).

lellky avatar Jun 13 '23 09:06 lellky