core icon indicating copy to clipboard operation
core copied to clipboard

Bump bluetooth deps for bleak 0.20

Open bdraco opened this issue 1 year ago • 5 comments

Proposed change

Bumps dependencies:

  • bleak to v0.20.0 [Compare] [Release]
  • dbus-fast to v1.84.2 [Compare] [Release]
  • bleak-retry-connector to v3.0.1 [Compare] [Release]
  • bluetooth-adapters https://github.com/Bluetooth-Devices/bluetooth-adapters/compare/v0.15.2...v0.15.3

originally opened by @kiwiz in #89906 (thank you!). Since the work to support 0.20.0 turned out to be substantial I picked this up to finish it.

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco avatar Mar 18 '23 20:03 bdraco

I need to update bleak-retry-connector as well

bdraco avatar Mar 18 '23 20:03 bdraco

/Users/bdraco/home-assistant/homeassistant/components/bluetooth/base_scanner.py:170: FutureWarning: BLEDevice.rssi is deprecated and will be removed in a future version of Bleak, use AdvertisementData.rssi instead
  "rssi": device_adv[0].rssi,

Need to fix this as well

bdraco avatar Mar 18 '23 20:03 bdraco

@kiwiz I think this should be good to go now if you want to try it out

bdraco avatar Mar 18 '23 22:03 bdraco

looks like there is another one

Mar 18 22:10:06 homeassistant homeassistant[484]: /usr/local/lib/python3.10/site-packages/bluetooth_adapters/history.py:36: FutureWarning: BLEDevice.rssi is deprecated and will be removed in a future version of Bleak, use AdvertisementData.rssi instead

bdraco avatar Mar 18 '23 22:03 bdraco

manual testing is good.

Just need the CI to pass now

bdraco avatar Mar 18 '23 22:03 bdraco

thanks

bdraco avatar Mar 20 '23 17:03 bdraco