core icon indicating copy to clipboard operation
core copied to clipboard

Add Velux config flow

Open DeerMaximum opened this issue 1 year ago • 2 comments

Breaking change

Proposed change

Add config flow to Velux

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/26455

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

DeerMaximum avatar Mar 04 '23 17:03 DeerMaximum

Hey there @julius2342, mind taking a look at this pull request as it has been labeled with an integration (velux) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of velux can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign velux Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Mar 04 '23 17:03 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Mar 06 '23 08:03 home-assistant[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Aug 23 '23 07:08 github-actions[bot]

Waiting for a new version of PyVLX that fixes the tests.

DeerMaximum avatar Aug 23 '23 10:08 DeerMaximum

Hey @DeerMaximum , can I contact you on discord?

pergolafabio avatar Sep 13 '23 06:09 pergolafabio

Hey @DeerMaximum , can I contact you on discord?

@pergolafabio Why?

DeerMaximum avatar Sep 13 '23 08:09 DeerMaximum

Hey @DeerMaximum , can I contact you on discord?

@pergolafabio Why?

wanted to ask if you could add 2 new attributes to the covers, seems you are only active on this integration

            _"limitation_min": self._extra_attr_limitation_min,
            "limitation_max": self._extra_attr_limitation_max,_

It was added long time ago in : https://github.com/Julius2342/pyvlx/pull/71 The limitaions (cover position 93% can tell if rain is detected yes or no, se we can have actually a rain sensor in HA

Progress was already done in this PR below, but it got stale/closed

https://github.com/home-assistant/core/pull/64628

pergolafabio avatar Sep 13 '23 08:09 pergolafabio

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Dec 08 '23 10:12 github-actions[bot]

Waiting for a new version of PyVLX that fixes the tests.

DeerMaximum avatar Dec 08 '23 16:12 DeerMaximum

(Send me a message on discord if you need help btw)

joostlek avatar Dec 23 '23 17:12 joostlek

Will this PR merged soon?

pawlizio avatar Dec 29 '23 20:12 pawlizio

Can we merge either this or the other velux config flow PR? There is a lot of other stuff depending on this.

pawlizio avatar Feb 11 '24 18:02 pawlizio