core icon indicating copy to clipboard operation
core copied to clipboard

Obihai: Add reboot service

Open ejpenney opened this issue 3 years ago • 2 comments

Proposed change

Adds a reboot service to Obihai devices.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/26385

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [X] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

ejpenney avatar Feb 27 '23 17:02 ejpenney

Hey there @dshokouhi, mind taking a look at this pull request as it has been labeled with an integration (obihai) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of obihai can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign obihai Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Feb 27 '23 17:02 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 27 '23 17:02 home-assistant[bot]

Oh - a merge conflict has appeared...

epenet avatar Mar 02 '23 06:03 epenet

Oh - a merge conflict has appeared...

I added init.py to .coveragerc in the other PR and buttons.py in this PR. Merge conflict should be resolved now.

ejpenney avatar Mar 02 '23 18:03 ejpenney