core icon indicating copy to clipboard operation
core copied to clipboard

Error checking Reolink firmware update

Open NickM-27 opened this issue 2 years ago • 5 comments

The problem

Screen Shot 2023-02-23 at 17 06 52 PM

Seeing this error. When I check the logs I do not see any stack traces, I just see this warning

2023-02-24 07:11:50.550 WARNING (MainThread) [homeassistant.config_entries] Config entry 'Front Doorbell' for reolink integration not ready yet: Error checking Reolink firmware update Front Doorbell Cam; Retrying in background

and then this debug log (among lots of other successful calls)

2023-02-24 07:11:50.372 DEBUG (MainThread) [reolink_aio.api.data] Front Doorbell Cam/192.168.50.151:443::send() HTTP Response data:
[
{
"cmd" : "CheckFirmware",
"code" : 1,
"error" : {
"detail" : "rcv failed",
"rspCode" : -17
}
},
{
"cmd" : "GetDevInfo",
"code" : 0,
"value" : {
"DevInfo" : {
"B485" : 0,
"IOInputNum" : 0,
"IOOutputNum" : 0,
"audioNum" : 1,
"buildDay" : "build 23010901",
"cfgVer" : "v3.0.0.0",
"channelNum" : 1,
"detail" : "DB_566128M5MP_WS10E1W7110000000",
"diskNum" : 1,
"exactType" : "WIFI_SOLO_IPC",
"firmVer" : "v3.0.0.1572_23010901",
"frameworkVer" : 1,
"hardVer" : "DB_566128M5MP_W",
"model" : "Reolink Video Doorbell WiFi",
"name" : "Front Doorbell Cam",
"pakSuffix" : "pak,paks",
"serial" : "00000000065668",
"type" : "IPC",
"wifi" : 1
}
}
}
]

What version of Home Assistant Core has the issue?

2022.3.0b1

What was the last working version of Home Assistant Core?

2022.2

What type of installation are you running?

Home Assistant Container

Integration causing the issue

reolink

Link to integration documentation on our website

https://www.home-assistant.io/integrations/reolink/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

NickM-27 avatar Feb 24 '23 14:02 NickM-27

Hey there @starkillerog, mind taking a look at this issue as it has been labeled with an integration (reolink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of reolink can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign reolink Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


reolink documentation reolink source (message by IssueLinks)

home-assistant[bot] avatar Feb 24 '23 14:02 home-assistant[bot]

@NickM-27 did you perhaps block internet acces for the Reolink Video Doorbell WiFi? Did you try checking for firmware updates in the reolink app/client? Does that succeed, or does that also give an error?

I will make sure that the integration can setup, even if a error occurs in the firmware update check.

starkillerOG avatar Feb 26 '23 17:02 starkillerOG

@NickM-27 did you perhaps block internet acces for the Reolink Video Doorbell WiFi? Did you try checking for firmware updates in the reolink app/client? Does that succeed, or does that also give an error?

I will make sure that the integration can setup, even if a error occurs in the firmware update check.

Yes I have all my cameras blocked from WAN, only internal communication is allowed. In the app checking for update just says no update available, wouldn't surprise me if they are just saying that and masking the fact that there is an error.

NickM-27 avatar Feb 26 '23 18:02 NickM-27

@NickM-27 yea if internet is blocked it is of course impossible to check for new firmware versions on the reolink servers. So the app/client must fail, it apperently is indeed just masking that it had an error. I will make sure the integration will not fail to setup, but of course the update entity will be marked as unavailable because it can not function if internet is blocked. Working on it now.

starkillerOG avatar Feb 26 '23 18:02 starkillerOG

@NickM-27 this PR https://github.com/home-assistant/core/pull/88797 schould fix the issue.

If you appreciate the reolink integration and want to support its development, please consider sponsering the upstream library.

starkillerOG avatar Feb 26 '23 18:02 starkillerOG

Fixed in #88797

balloob avatar Mar 01 '23 16:03 balloob