core icon indicating copy to clipboard operation
core copied to clipboard

Calculate _attr_native_value when no restore state and appliance is running in Whirlpool

Open mkmer opened this issue 2 years ago • 2 comments

Proposed change

Currently, if the appliance is running when the integration is added (aka restore state is None), the time stamp will not be calculated until the appliance finishes a cycle. This change will allow a time stamp to be set if the appliance is running when the integration is added.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

mkmer avatar Feb 21 '23 19:02 mkmer

Hey there @abmantis, mind taking a look at this pull request as it has been labeled with an integration (whirlpool) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of whirlpool can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign whirlpool Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Feb 21 '23 19:02 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 22 '23 08:02 home-assistant[bot]

I believe the requested changes have been satisfied. What do I need to do to get this over the bar?

mkmer avatar Apr 10 '23 11:04 mkmer

Stuck?

mkmer avatar May 23 '23 17:05 mkmer