core icon indicating copy to clipboard operation
core copied to clipboard

Make OTBR use same channel as ZHA

Open emontnemery opened this issue 2 years ago • 4 comments

Proposed change

Make OTBR use same channel as ZHA

TODO: tests

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

emontnemery avatar Feb 21 '23 14:02 emontnemery

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (otbr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of otbr can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign otbr Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Feb 21 '23 14:02 home-assistant[bot]

Hey there @dmulcahey, @adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign zha Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Feb 21 '23 14:02 home-assistant[bot]

Please note that OTBR should only same channel as ZHA if using both via multiprotocol support on the same Multi-PAN RCP adapter, and not when using OTBR on different adapters (e.g. separate dedicated adapters for Zigbee and OpenThread).

That is, please keep in mind there is a use case scenario where an end-user will have two Home Assistant SkyConnect dongles and use one dongle only for Zigbee with the ZHA integration and the other dongle only for OTBR.

So using the same channel for OTBR as ZHA by default is probably not a solution that will fit all users.

PS: Personally I currently using ITead’s CC2652-based “Sonoff Zigbee 3.0 USB Dongle Plus” dongle for ZHA and am at least for now planning to use my first Home Assistant SkyConnect dongle only as a dedicated OpenThread Border Router.

Hedda avatar Feb 22 '23 17:02 Hedda

@Hedda you're right, what's in this PR is a quick (and somewhat dirty) fix which hopefully can be included in HA Core 2023.3. In a future release, it should indeed be improved to cover the cases you mention 👍

emontnemery avatar Feb 27 '23 12:02 emontnemery

@Hedda The implementation has now been reworked so we only force the OTBR to use the same channel as ZHA if they're both using the multi-PAN radio.

emontnemery avatar Mar 23 '23 08:03 emontnemery