Add Freebox cameras

[nachonam]

trafficstars

Breaking change

Proposed change

Plan for implementing all Freebox Home sensors (cameras, pir,dws,remote commands..) and alarm system.

Type of change

• [ ] Dependency upgrade
• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [X] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] The code has been formatted using Black (black --fast homeassistant tests)
• [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [x] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [X] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [X] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @hacf-fr, @quentame, mind taking a look at this pull request as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign freebox Removes the current integration label and assignees on the issue, add the integration domain after the command.

[nachonam]

Hello, A little PR to add Freebox cameras to HA Regards

[BenoitAnastay]

Also you do not seem to have updated units tests

https://github.com/home-assistant/core/tree/dev/tests/components/freebox

[nachonam]

Also you do not seem to have updated units tests

https://github.com/home-assistant/core/tree/dev/tests/components/freebox

I'm working on... 75% covered

[emontnemery]

I'm marking this as draft, please set to ready for review when the tests have been updated 👍

[nachonam]

I'm marking this as draft, please set to ready for review when the tests have been updated +1

88% is enough?

> --------- coverage: platform linux, python 3.10.9-final-0 -----------
> Name                                              Stmts   Miss  Cover   Missing
> -------------------------------------------------------------------------------
> homeassistant/components/freebox/__init__.py         50      2    96%   54-55
> homeassistant/components/freebox/base_class.py       99     43    57%   38-39, 49-54, 69, 89-97, 101-109, 113-125, 134-137, 142-154, 158-171
> homeassistant/components/freebox/button.py           32      0   100%
> homeassistant/components/freebox/camera.py          113     11    90%   72, 144, 149, 153, 157-158, 170-173, 178-181, 191
> homeassistant/components/freebox/config_flow.py      57      0   100%
> homeassistant/components/freebox/const.py            28      0   100%
> homeassistant/components/freebox/router.py          128      7    95%   43, 163-165, 182, 234, 244
> -------------------------------------------------------------------------------
> TOTAL                                               507     63    88%

[BenoitAnastay]

88% is enough?

I was looking for answers in the documentation but I do not find any specified value except the use of the word full.

But I guess it's enough, since there is tests and they do work it's fine.

[nachonam]

88% is enough?

I was looking for answers in the documentation but I do not find any specified value except the use of the word full.

But I guess it's enough, since there is tests and they do work it's fine.

Ok, good... So can I commit the last modifications to this PR or I need to close this PR and open another one?

[BenoitAnastay]

There is a button somewhere to flag it ready for reviews

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

[Quentame]

You can mark a PR as ready by clicking the "Ready for review" button on the bottom of the page.

[HpNoTiQ56]

Hi, Thanks a lot for taking the time to integrate freebox delta. BTW, @echauvet has done some PR last year and integration which are fully working (except alarm not supported). https://github.com/home-assistant/core/pull/63711 https://github.com/home-assistant/core/pull/64018 https://github.com/echauvet/freebox_home

[echauvet]

Hi,

Alarm, RTS, IOHomeControl, Caméra are integrated. This works at home and Friends homes without any issues for months. Just clone repo in your custom_components folder. Have fun, Eric

Le ven. 3 mars 2023, 22:03, HpNoTiQ @.***> a écrit :

Hi, Thanks a lot for taking the time to integrate freebox delta. BTW, @echauvet https://github.com/echauvet has done some PR last year and integration which are fully working (except alarm not supported). #63711 https://github.com/home-assistant/core/pull/63711 #64018 https://github.com/home-assistant/core/pull/64018 https://github.com/echauvet/freebox_home

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/88104#issuecomment-1454126205, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZEPMPTKJX2O4CGJT6BTLW2JMCHANCNFSM6AAAAAAU3Z62V4 . You are receiving this because you were mentioned.Message ID: @.***>

[HpNoTiQ56]

Hi, Alarm, RTS, IOHomeControl, Caméra are integrated. This works at home and Friends homes without any issues for months. Just clone repo in your custom_components folder. Have fun, Eric Le ven. 3 mars 2023, 22:03, HpNoTiQ @.> a écrit : … Hi, Thanks a lot for taking the time to integrate freebox delta. BTW, @echauvet https://github.com/echauvet has done some PR last year and integration which are fully working (except alarm not supported). #63711 <#63711> #64018 <#64018> https://github.com/echauvet/freebox_home — Reply to this email directly, view it on GitHub <#88104 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZEPMPTKJX2O4CGJT6BTLW2JMCHANCNFSM6AAAAAAU3Z62V4 . You are receiving this because you were mentioned.Message ID: @.>

Everything is working except alarm commands (Arming away/arming home/Disarm/Engage now ("passer le délai")).

[echauvet]

Your're right I forgot that. This could be done easely. Eric

Le dim. 5 mars 2023, 08:18, HpNoTiQ @.***> a écrit :

Hi, Alarm, RTS, IOHomeControl, Caméra are integrated. This works at home and Friends homes without any issues for months. Just clone repo in your custom_components folder. Have fun, Eric Le ven. 3 mars 2023, 22:03, HpNoTiQ @.

> a écrit : … <#m_1703486343386180046_m_6826553584305156454_> Hi, Thanks a lot for taking the time to integrate freebox delta. BTW, @echauvet https://github.com/echauvet https://github.com/echauvet https://github.com/echauvet has done some PR last year and integration which are fully working (except alarm not supported). #63711 https://github.com/home-assistant/core/pull/63711 <#63711 https://github.com/home-assistant/core/pull/63711> #64018 https://github.com/home-assistant/core/pull/64018 <#64018 https://github.com/home-assistant/core/pull/64018> https://github.com/echauvet/freebox_home https://github.com/echauvet/freebox_home — Reply to this email directly, view it on GitHub <#88104 (comment) https://github.com/home-assistant/core/pull/88104#issuecomment-1454126205>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZEPMPTKJX2O4CGJT6BTLW2JMCHANCNFSM6AAAAAAU3Z62V4 https://github.com/notifications/unsubscribe-auth/ABEZEPMPTKJX2O4CGJT6BTLW2JMCHANCNFSM6AAAAAAU3Z62V4 . You are receiving this because you were mentioned.Message ID: @.>

Everything is working except alarm commands (Arming away/arming home/Disarm/Engage now ("passer le délai")). [image: image] https://user-images.githubusercontent.com/17127386/222947265-695f3756-9f14-4ded-bcdb-8d9240f9fd60.png

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/88104#issuecomment-1455011365, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZEPK2NRYHYIFJMGP7M7DW2Q45PANCNFSM6AAAAAAU3Z62V4 . You are receiving this because you were mentioned.Message ID: @.***>

[nachonam]

Hello,

Thanks for this info and for this freebox custom plugin.

In the past, I have tried to push a full freebox plugin (with alarm, camera, pir, somfy ....) but the PR was a little complex... so I've split the PR, and I started with this little PR adding only cameras...

I'll check your dev and I'll try to merge ....

Regards,

Your're right I forgot that. This could be done easely. Eric Le dim. 5 mars 2023, 08:18, HpNoTiQ @.> a écrit : … Hi, Alarm, RTS, IOHomeControl, Caméra are integrated. This works at home and Friends homes without any issues for months. Just clone repo in your custom_components folder. Have fun, Eric Le ven. 3 mars 2023, 22:03, HpNoTiQ @. > a écrit : … <#m_1703486343386180046_m_6826553584305156454_> Hi, Thanks a lot for taking the time to integrate freebox delta. BTW, @echauvet https://github.com/echauvet https://github.com/echauvet https://github.com/echauvet has done some PR last year and integration which are fully working (except alarm not supported). #63711 <#63711> <#63711 <#63711>> #64018 <#64018> <#64018 <#64018>> https://github.com/echauvet/freebox_home https://github.com/echauvet/freebox_home — Reply to this email directly, view it on GitHub <#88104 (comment) <#88104 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZEPMPTKJX2O4CGJT6BTLW2JMCHANCNFSM6AAAAAAU3Z62V4 https://github.com/notifications/unsubscribe-auth/ABEZEPMPTKJX2O4CGJT6BTLW2JMCHANCNFSM6AAAAAAU3Z62V4 . You are receiving this because you were mentioned.Message ID: @.> Everything is working except alarm commands (Arming away/arming home/Disarm/Engage now ("passer le délai")). [image: image] https://user-images.githubusercontent.com/17127386/222947265-695f3756-9f14-4ded-bcdb-8d9240f9fd60.png — Reply to this email directly, view it on GitHub <#88104 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEZEPK2NRYHYIFJMGP7M7DW2Q45PANCNFSM6AAAAAAU3Z62V4 . You are receiving this because you were mentioned.Message ID: @.>

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[nachonam]

2 questions + 1 change: after that I'm good for a merge

Yes! Great job! Thanks