Add Water device class to Overkiz

[tetienne]

Breaking change

Proposed change

Since the introduction of the device class water, we didn’t update the Overkiz integration to support it. It’s now the case, and found two sensors eligible.

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #83736
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [ ] The code change is tested and works locally.
• [ ] Local tests pass. Your PR cannot be merged unless tests pass
• [ ] There is no commented out code in this PR.
• [ ] I have followed the development checklist
• [ ] The code has been formatted using Black (black --fast homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @imicknl, @vlebourl, @nyrodev, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign overkiz Removes the current integration label and assignees on the issue, add the integration domain after the command.

[MassimoL06]

Hello, when I force "device_class: water" and "state_class: total_increasing" to my water sensor entity from the Developer Tools TAB like this, I am able to add this entity to the energy dashboard.

Hope it helps.

[vlebourl]

I had a closer look at both dhwp_actuator_water_consumption and dhwp_actuator_water_volume_estimation_at_40_degc. Here you have both on the same timeline

From this, I would argue that

• Water volume estimation at 40 °C is indeed a water consumption, altghough it's an estimate rather than a direct measurement, and its state_class should be TOTAL_INCREASING
• Water consumption is not a water consumption and should stay a VOLUME device class (the slow decreases correspond to cooling inside the tank, not consumption).

[epenet]

Please also take a look at https://github.com/home-assistant/core/pull/88312 which adds a new device class

[MassimoL06]

Hello @vlebourl I agree with your comment regarding dhwp_actuator_water_consumption and dhwp_actuator_water_volume_estimation_at_40_degc. Another concern regarding dhwp_actuator_water_volume_estimation_at_40_degc is that it has a maximum value of 65535, then retarts to 0. Is it possible to extend the range value by using a 32 bits variable ?

How do you create your ApexChart-Card ? Regards

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.