core icon indicating copy to clipboard operation
core copied to clipboard

State attributes translation for Sensibo

Open gjohansson-ST opened this issue 2 years ago • 5 comments

Proposed change

SSIA

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

gjohansson-ST avatar Jan 05 '23 19:01 gjohansson-ST

Hey there @andrey-git, mind taking a look at this pull request as it has been labeled with an integration (sensibo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensibo can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign sensibo Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Jan 05 '23 19:01 home-assistant[bot]

@gjohansson-ST Why did you close this PR? Seems like a viable one to add?

frenck avatar Jan 08 '23 16:01 frenck

I had a discussion with @emontnemery to understand more exactly how translations was intended to work and after a few further tests I could not get it to translate the attributes for neither sensor nor switch. I understood it's not fully complete yet with these translations (only climate so far) and thereby maybe it's not enough completed in frontend to deal with my suggestion.

gjohansson-ST avatar Jan 08 '23 16:01 gjohansson-ST

further tests I could not get it to translate the attributes for neither sensor nor switch.

That is frontend which is not ready yet, that doesn't mean we can't add them already?

frenck avatar Jan 08 '23 16:01 frenck

True. Let's do that. I will modify it. Thanks

gjohansson-ST avatar Jan 08 '23 16:01 gjohansson-ST

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 12 '23 19:02 home-assistant[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar May 13 '23 20:05 github-actions[bot]

Not stale

gjohansson-ST avatar May 14 '23 07:05 gjohansson-ST

Set to draft after discussion on discord about capital letters in attribute names and attribute states

emontnemery avatar Jun 28 '23 09:06 emontnemery

Example: image

gjohansson-ST avatar Jul 09 '23 11:07 gjohansson-ST