core icon indicating copy to clipboard operation
core copied to clipboard

Cannot specify stream_quality or image_quality for proxy camera integration

Open parautenbach opened this issue 2 years ago • 15 comments

The problem

Dec 26 17:11:50 homeassistant hass[14516]:   File "/srv/homeassistant/lib/python3.9/site-packages/homeassistant/components/proxy/camera.py", line 106, in _resize_image
Dec 26 17:11:50 homeassistant hass[14516]:     if old_width <= new_width:
Dec 26 17:11:50 homeassistant hass[14516]: TypeError: '<=' not supported between instances of 'int' and 'NoneType'

What version of Home Assistant Core has the issue?

core-2022-10.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

proxy

Link to integration documentation on our website

https://www.home-assistant.io/integrations/proxy/

Diagnostics information

No response

Example YAML snippet

- platform: proxy
  name: security_camera_proxy
  entity_id: camera.security_camera
  stream_quality: 1
  image_quality: 1


### Anything in the logs that might be useful for us?

_No response_

### Additional information

I know I'm running a 2-month old version, but checking the code of the current main branch, it's still the same code. 

I thought perhaps the documentation is incorrect showing an integer value between 0 and 100, so I tried a float value in the range 0-1 too. 

parautenbach avatar Dec 26 '22 15:12 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Mar 26 '23 19:03 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Jun 25 '23 13:06 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Sep 23 '23 19:09 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Dec 23 '23 06:12 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Mar 22 '24 07:03 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Still an issue.

parautenbach avatar Jun 20 '24 08:06 parautenbach

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Sep 18 '24 09:09 parautenbach

.

JohnMcLear avatar Oct 03 '24 11:10 JohnMcLear

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

.

parautenbach avatar Jan 01 '25 11:01 parautenbach

New width doesn't appear to default. So set max_stream_width in your config. Assuming size won't change just set to your full size image.

cdnninja avatar Feb 13 '25 19:02 cdnninja

I think this is a valid report and seems to be a fairly easy fix. I've opened a pull request in #141676 for review to address it.

../Frenck

frenck avatar Mar 28 '25 18:03 frenck

That's great to hear.

parautenbach avatar Mar 28 '25 19:03 parautenbach