core icon indicating copy to clipboard operation
core copied to clipboard

FullyKiosk: number entity state for screen brightness is "unknown" if "screenBrightness" is empty

Open bcutter opened this issue 3 years ago • 4 comments

The problem

When fully kiosk key screenBrightness is empty (so there's no fixed value for screen brightness but the automatic mode of the device activated), the corresponding entity number.kiosk_tablet_screen_brightness is of state unknown.

FK web config: grafik

HA: grafik

What version of Home Assistant Core has the issue?

core-2022.9.7

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

fully_kiosk

Link to integration documentation on our website

https://www.home-assistant.io/integrations/fully_kiosk

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

I still don't like the decision of splitting the former (custom integration) light.device entity into a switch and separate number entity...

bcutter avatar Dec 17 '22 21:12 bcutter

Hey there @cgarwood, mind taking a look at this issue as it has been labeled with an integration (fully_kiosk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fully_kiosk can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign fully_kiosk Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


fully_kiosk documentation fully_kiosk source (message by IssueLinks)

home-assistant[bot] avatar Dec 17 '22 21:12 home-assistant[bot]

I'm not sure what you're expecting to happen here. If Fully Kiosk is returning an empty value for the screen brightness, what should the integration do besides report unknown?

mheath avatar Feb 23 '23 06:02 mheath

Empty = device's auto mode should be replaced with a corresponding value (0-255). As simple as that. Screen brightness always has a value, it never is "nothing" so no need for unknown.

bcutter avatar Feb 23 '23 07:02 bcutter

Since empty=device's auto mode, replacing it with something else would no longer reflect the actual value of the screen brightness setting. Similar to the screensaver brightness, this is a setting not something that reflects that device's actual brightness. It is confusing given that the screensaver brightness is categorized as "configuration" and screen brightness is categorized as "Controls."

Correct me if I'm wrong but I believe what you're looking for is a sensor entity that reports the screen's actual brightness rather than a number entity used for configuring the device.

mheath avatar Apr 26 '23 22:04 mheath

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Open

bcutter avatar Jul 31 '23 08:07 bcutter

The screen brightness entity is working as designed. Why are we leaving this issue open? If you want a screen brightness sensor, let's create a new issue for that.

mheath avatar Jul 31 '23 15:07 mheath

I described everything in the OP. unknown is a magic state (like unavailable) out of the category "problematic". Using the device in screen brightness auto mode is not a problematic state. That's what this issue is about. Another issue won't do nothing I guess.

bcutter avatar Jul 31 '23 21:07 bcutter

Please take this up with FKB. From the FKB docs "Screen Brightness – Set screen brightness 0…255, leave empty for system default". The HA integration is working as designed.

mheath avatar Aug 11 '23 06:08 mheath

Only the fact the current implementation is documented does not mean it is a good implementation.

Repeating myself again: UNKNOWN is a problematic state. System controlled screen brightness could be represented as 0 (zero), as this would be a non-problematic state and screen brightness never can be zero (screen off is represented by the light entity, not the number entity this issue is about).

bcutter avatar Aug 11 '23 08:08 bcutter

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

https://github.com/home-assistant/core/issues/84154#issuecomment-1674399988

bcutter avatar Nov 09 '23 09:11 bcutter

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

https://github.com/home-assistant/core/issues/84154#issuecomment-1674399988

bcutter avatar Feb 07 '24 15:02 bcutter

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

https://github.com/home-assistant/core/issues/84154#issuecomment-1674399988

bcutter avatar May 07 '24 18:05 bcutter

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

I think here's nothing gonna happen anymore.

https://github.com/home-assistant/core/issues/84154#issuecomment-1674399988

bcutter avatar Aug 05 '24 19:08 bcutter