core
core copied to clipboard
Fix tuya camera stream
Proposed change
Tuya camera streams have one time streaming urls. Home Assistant is reusing the camera stream attribute. If no data is read from the stream, Tuya closed the stream permanently. See #58614
Type of change
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #58614
- This PR is related to issue: #68503
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] The code has been formatted using Black (
black --fast homeassistant tests
) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya
) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of tuya
can trigger bot actions by commenting:
-
@home-assistant close
Closes the issue. -
@home-assistant rename Awesome new title
Change the title of the issue. -
@home-assistant reopen
Reopen the issue. -
@home-assistant unassign tuya
Removes the current integration label and assignees on the issue, add the integration domain after the command.
Hey there,
Not sure if i am supposed to post this here, but for wich Tuya intergration is this going to count for? is this the regular Tuya or the Tuya V2.
As i am reading this the problem with the Tuya camera's is that the stream url only has an 1 time usage or an certain amount of time to stay up?
Hey there,
Not sure if i am supposed to post this here, but for wich Tuya intergration is this going to count for? is this the regular Tuya or the Tuya V2.
As i am reading this the problem with the Tuya camera's is that the stream url only has an 1 time usage or an certain amount of time to stay up?
Of course Tuya. Tuya V2 is death and doesn't support cameras at all.
Hi, is this fix also related to my issue i'm having? I dont have an RTSP stream, only webrtc when i do the API request on IOT platform
https://github.com/home-assistant/core/issues/84241
Any work still being done on this? I tested the changes but it still seems to timeout and the stream stops working.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
I'm using the official tuya integration and the image from no camera can be viewed. I'm using the latest version of HA.
Can anybody help me?
Any update on when this can be rolled out?
Not in 2023.6.1?
Sold my Tuya cameras and bought Eufy ones because those actually work with HA...
How is the progress of this? Can we expect it to be merged soon?
Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.
Feel free to re-open this PR when you are ready to pick up work on it again 👍