core icon indicating copy to clipboard operation
core copied to clipboard

Allow configuring country and language in core config

Open emontnemery opened this issue 1 year ago • 1 comments

Proposed change

Allow configuring country and language in core config

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

emontnemery avatar Nov 07 '22 17:11 emontnemery

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (config) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of config can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign config Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Nov 07 '22 17:11 home-assistant[bot]

What's this feature for, though? There seems to be no reference as to why this needs to be done.

akx avatar Nov 07 '22 18:11 akx

What's this feature for, though? There seems to be no reference as to why this needs to be done.

The PR description has been updated to give a motivation.

emontnemery avatar Nov 07 '22 19:11 emontnemery

Could be useful in one of my PR : #81167

Quentame avatar Nov 14 '22 01:11 Quentame

Should this raise an repair issue when country isn't set?

frenck avatar Nov 22 '22 12:11 frenck

Should this raise an repair issue when country isn't set?

Sure. Let's do that in a follow-up though 👍

emontnemery avatar Nov 22 '22 13:11 emontnemery

@emontnemery Don't forget to adjust the user documentation for this change.

frenck avatar Nov 24 '22 22:11 frenck

Documentation: https://github.com/home-assistant/home-assistant.io/pull/25047

emontnemery avatar Nov 25 '22 11:11 emontnemery