core icon indicating copy to clipboard operation
core copied to clipboard

chore(lutron): rm myself from codeowners

Open JonGilmore opened this issue 2 years ago • 4 comments

Breaking change

Proposed change

I have switched to Lutron RadioRA3 and no longer own a RA2 system

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

JonGilmore avatar Nov 07 '22 14:11 JonGilmore

whoops, thanks - good catch. should I just tag a core dev in here to take a look at this?

JonGilmore avatar Nov 07 '22 16:11 JonGilmore

Yes please @JonGilmore . I think another file needs to be updated but I can't recall which one it is.

Rudd-O avatar Nov 07 '22 16:11 Rudd-O

Please don't suggest tagging core devs asking for reviews.

ADR0008 outlines withdrawing as a code owner : https://github.com/home-assistant/architecture/blob/master/adr/0008-code-owners.md#withdrawing-as-a-code-owner

Also this PR needs hassfest run as described in the opening text

bdraco avatar Nov 07 '22 17:11 bdraco

Please don't suggest tagging core devs asking for reviews.

Sorry. I was not aware of this process.

Rudd-O avatar Nov 07 '22 17:11 Rudd-O

Thanks @bdraco - this is now ready for review.

JonGilmore avatar Nov 08 '22 02:11 JonGilmore

Thanks @JonGilmore

bdraco avatar Nov 08 '22 03:11 bdraco

Sad to see this integration without a code owner, but I think that was inevitable as nobody wants to be running the older systems anymore 😄

Tagging @cdheiser - any chance you still have ra2 and would be interested in picking up CODEOWNERS for lutron?

JonGilmore avatar Nov 08 '22 03:11 JonGilmore

I do and I would be interested in picking up CODE OWNERS for lutron. Did everyone upgrade to RadioRA 3 already!?

On Mon, Nov 7, 2022, 7:27 PM Jon Gilmore @.***> wrote:

Sad to see this integration without a code owner, but I think that was inevitable as nobody wants to be running the older systems anymore 😄

Tagging @cdheiser https://github.com/cdheiser - any chance you still have ra2 and would be interested in picking up CODEOWNERS for lutron?

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/81727#issuecomment-1306576755, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWWVSR2XRBDB3M4HCMTWHHCAZANCNFSM6AAAAAARZIMDIU . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Nov 08 '22 04:11 cdheiser

Right on, thanks buddy! I recently moved homes and with all the development for ra3 in https://github.com/gurumitts/pylutron-caseta - it didn't seem like a smart decision to invest in ra2 :D

JonGilmore avatar Nov 08 '22 12:11 JonGilmore