core
core copied to clipboard
Correct zamg config flow comments
Breaking change
Proposed change
Changes mentioned by @MartinHjelmare during merge: https://github.com/home-assistant/core/pull/66469#pullrequestreview-1158004866
Type of change
- [X] Dependency upgrade (https://github.com/killer0071234/python-zamg/releases/tag/v0.1.2)
- [X] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [X] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [X] The code change is tested and works locally.
- [X] Local tests pass. Your PR cannot be merged unless tests pass
- [X] There is no commented out code in this PR.
- [X] I have followed the development checklist
- [X] The code has been formatted using Black (
black --fast homeassistant tests
) - [X] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [x] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [X] I have reviewed two other open pull requests in this repository.
Remove it from the milestone, as we are ready to ship at this point.
@killer0071234 I'm not sure how far this change has progressed, but are you confident that this PR is ready to be merged in time for the January release? Or maybe we could split the ZAMG library version bump into a different/smaller PR, so that the timestamp fix is merged ASAP?
@killer0071234 I'm not sure how far this change has progressed, but are you confident that this PR is ready to be merged in time for the January release? Or maybe we could split the ZAMG library version bump into a different/smaller PR, so that the timestamp fix is merged ASAP?
I agree to have a small PR for the timestamp fix. I need to dig into it to see what has changed in python zamg between the current one and the new one.