core icon indicating copy to clipboard operation
core copied to clipboard

Replace led-ble util with bluetooth-data-tools

Open bdraco opened this issue 1 year ago • 1 comments

Proposed change

Replace led-ble util with bluetooth-data-tools

ref: https://github.com/home-assistant/core/pull/77489#discussion_r1006512952

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco avatar Oct 27 '22 14:10 bdraco

Too many things are using "bluetooth-data-tools" so better move the pin to the bluetooth integration instead and let everything depend on that since the bluetooth integration is already going to load it and we need a newer version in the pin

bdraco avatar Oct 27 '22 14:10 bdraco

leaving as draft until https://github.com/home-assistant/core/pull/81109 merges since it will conflict and this one can wait for next month

bdraco avatar Oct 27 '22 18:10 bdraco

Good to merge after Nov 10 if there are no other dbus bumps

bdraco avatar Nov 01 '22 20:11 bdraco

Thanks

bdraco avatar Nov 08 '22 13:11 bdraco

I'm hoping no more dbus_fast bumps for a while but I'm almost afraid to write that 🙈

bdraco avatar Nov 08 '22 13:11 bdraco