core icon indicating copy to clipboard operation
core copied to clipboard

Fix Snapcast connection issues

Open luar123 opened this issue 2 years ago • 1 comments

Proposed change

Fixes issues related to the connection to the snapcast server:

  • terminate connection when needed
  • handle disconnect/reconnect and set entity availability accordingly
  • listen for updates from server and add/remove/update entities
  • better handling of errors
  • setting iot_class to local_push, has not used polling in a long time

Should push the Integration quality to silver.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

This PR depends on #80288

  • This PR fixes or closes issue: fixes #63928
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

luar123 avatar Oct 23 '22 20:10 luar123

Please merge #80288 first, only the last two commits belong to this PR. Made this a draft because I am still waiting for a upstream bug fix and although everything is working on my installation I am not sure if everything is done in the proper way. So some feedback is much appreciated.

luar123 avatar Oct 23 '22 20:10 luar123

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jan 28 '23 17:01 github-actions[bot]

waiting for review and #80288

luar123 avatar Jan 28 '23 17:01 luar123

I'll close here as this PR is blocked by another PR. Please open a new PR when the needed PR is merged.

MartinHjelmare avatar Jan 30 '23 11:01 MartinHjelmare