core icon indicating copy to clipboard operation
core copied to clipboard

Hive add ability to delete device

Open KJonline opened this issue 1 year ago • 2 comments

Breaking change

Proposed change

Implement async_remove_config_entry_device to allow devices to be deleted within the hive integration.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] The code has been formatted using Black (black --fast homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

KJonline avatar Oct 23 '22 19:10 KJonline

Hey there @rendili, mind taking a look at this pull request as it has been labeled with an integration (hive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hive can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign hive Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Oct 23 '22 19:10 home-assistant[bot]

@frenck not sure what to do here the failure in the GitHub actions doesn’t seem to be code related.

KJonline avatar Oct 27 '22 07:10 KJonline

Please can this be reviewed for the next release?

KJonline avatar Dec 02 '22 18:12 KJonline

Would dearly love this feature in the Hive integration so I could finally tidy up the orphaned and duplicate Hive devices I've accumulated over time in HA (rather than just disabling them). Did it make it to the 2022.12 release for testing?

SignUp0 avatar Dec 13 '22 22:12 SignUp0