core icon indicating copy to clipboard operation
core copied to clipboard

Add nextcloud config flow

Open Hadatko opened this issue 3 years ago • 4 comments

Breaking change

Proposed change

Adds ability to set verify_ssl for Nextcloud integration. (Needed for self-signed certificates)

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #55431
  • This PR is related to issue: #55431 #55433
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] The code has been formatted using Black (black --fast homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [X] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Hadatko avatar Oct 22 '22 13:10 Hadatko

Hey there @meichthys, mind taking a look at this pull request as it has been labeled with an integration (nextcloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nextcloud can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign nextcloud Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Oct 22 '22 13:10 home-assistant[bot]

The code is waiting for testing by author @meichthys

Hadatko avatar Oct 22 '22 13:10 Hadatko

Some errors are not related to my changes i guess: image

Hadatko avatar Oct 22 '22 14:10 Hadatko

I think we may need some changes to the docs to remove the manual config entry setup, and to indicate that it is setup via config flow.

meichthys avatar Oct 24 '22 11:10 meichthys

@meichthys were you able to test it?

Hadatko avatar Oct 26 '22 12:10 Hadatko

Not yet. Perhaps this evening.

meichthys avatar Oct 26 '22 12:10 meichthys

Hi @MartinHjelmare i noticed you made change here. Are you able to configm that build error is not related to our changes?

Hadatko avatar Oct 26 '22 12:10 Hadatko

@Hadatko I could have something setup incorrectly, but i'm getting the following when trying to add the nextcloud integration: Screen Shot 2022-10-27 at 1 15 08 AM I have your changes pulled in so i'm not sure what's off yet since i don't have time to dig in.

meichthys avatar Oct 27 '22 05:10 meichthys

@Hadatko you need to run the scripts mentioned in the build errors and commit the changes.

MartinHjelmare avatar Oct 27 '22 05:10 MartinHjelmare

@Hadatko you need to run the scripts mentioned in the build errors and commit the changes.

Did you read the error? If i run script it will remove my dependency. But error is with one different component. Shouldn't you fix that one component instead???

Hadatko avatar Oct 28 '22 05:10 Hadatko

Try adding the missing __init__.py module in the test package and then run script/gen_requirements_all.py.

The error is not with a different integration.

MartinHjelmare avatar Oct 28 '22 06:10 MartinHjelmare

Try adding the missing __init__.py module in the test package and then run script/gen_requirements_all.py.

The error is not with a different integration.

Ok then error message is not clear. I see there is warning for other integration not error. I will add missing init script manually then. Thank you for helping with this.

Hadatko avatar Oct 28 '22 07:10 Hadatko

Hello, @Hadatko are there any news on this PR? I've worked on implementing the config flow for this integration aswell. If you are planning to finish this, we could allign and split the work. I am available on the Discord (Peter#4446). best regards

devPeete avatar Dec 11 '22 12:12 devPeete

@devPeete Hi, yeah i postponed changes as i was working on different automatizations. I am happy to connect with your changes.

Hadatko avatar Dec 11 '22 12:12 Hadatko

@devPeete Can you make PR into my PR in my fork? We can discuss future steps there...

Hadatko avatar Dec 12 '22 19:12 Hadatko

@devPeete Can you make PR into my PR in my fork? We can discuss future steps there...

I've opened a PR to your repository. Besides testing the config_flow everything is done from the checklist. @meichthys do you want to stay Codeowner together with me and @Hadatko?

devPeete avatar Dec 14 '22 19:12 devPeete

@devPeete Can you make PR into my PR in my fork? We can discuss future steps there...

I've opened a PR to your repository. Besides testing the config_flow everything is done from the checklist. @meichthys do you want to stay Codeowner together with me and @Hadatko?

Things have changed enough that I think you can remove me from being a code owner 👍 Thanks for checking.

meichthys avatar Dec 14 '22 19:12 meichthys

Hello @Hadatko,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

home-assistant[bot] avatar Dec 14 '22 20:12 home-assistant[bot]

@Hadatko Oh, seems like the Git env of my Linux system was misconfigured. I linked the e-maill now to my GitHub account. Hope this is enough.

devPeete avatar Dec 14 '22 22:12 devPeete

Please start over in a new PR and branch. The branch is tainted with unrelated commits and you've included 13 other unrelated contributors as participants that will now get notifications for every update of this PR. We're still early in review and won't lose too much history.

MartinHjelmare avatar Dec 18 '22 10:12 MartinHjelmare

@devPeete as you see this PR is closed. I think it would be best if you create new PR

Hadatko avatar Dec 19 '22 09:12 Hadatko