core
core copied to clipboard
Add nextcloud config flow
Breaking change
Proposed change
Adds ability to set verify_ssl for Nextcloud integration. (Needed for self-signed certificates)
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #55431
- This PR is related to issue: #55431 #55433
- Link to documentation pull request:
Checklist
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. Your PR cannot be merged unless tests pass
- [X] There is no commented out code in this PR.
- [X] I have followed the development checklist
- [X] The code has been formatted using Black (
black --fast homeassistant tests
) - [X] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [X] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [X] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @meichthys, mind taking a look at this pull request as it has been labeled with an integration (nextcloud
) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of nextcloud
can trigger bot actions by commenting:
-
@home-assistant close
Closes the issue. -
@home-assistant rename Awesome new title
Change the title of the issue. -
@home-assistant unassign nextcloud
Removes the current integration label and assignees on the issue, add the integration domain after the command.
The code is waiting for testing by author @meichthys
Some errors are not related to my changes i guess:
I think we may need some changes to the docs to remove the manual config entry setup, and to indicate that it is setup via config flow.
@meichthys were you able to test it?
Not yet. Perhaps this evening.
Hi @MartinHjelmare i noticed you made change here. Are you able to configm that build error is not related to our changes?
@Hadatko I could have something setup incorrectly, but i'm getting the following when trying to add the nextcloud integration:
I have your changes pulled in so i'm not sure what's off yet since i don't have time to dig in.
@Hadatko you need to run the scripts mentioned in the build errors and commit the changes.
@Hadatko you need to run the scripts mentioned in the build errors and commit the changes.
Did you read the error? If i run script it will remove my dependency. But error is with one different component. Shouldn't you fix that one component instead???
Try adding the missing __init__.py
module in the test package and then run script/gen_requirements_all.py
.
The error is not with a different integration.
Try adding the missing
__init__.py
module in the test package and then runscript/gen_requirements_all.py
.The error is not with a different integration.
Ok then error message is not clear. I see there is warning for other integration not error. I will add missing init script manually then. Thank you for helping with this.