core icon indicating copy to clipboard operation
core copied to clipboard

Verisure

Open niro1987 opened this issue 3 years ago • 2 comments

Breaking change

The Verisure integration needs to be re-authenticated after the update because the integration is build on a new API. Mouse detectors have been removed due to a lack of available testers with these types of devices.

Proposed change

The python-verisure pakcage has been updated to work with the new GraphQL API instead of the old REST API. New Verisure devices like the Danalock Smartlock and cameras with motion detection are only supported in the new API.

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes #79411, #76620 and #76306
  • Link to the documentation pull request: 24654
  • Link to the compare between versions: https://github.com/persandstrom/python-verisure/compare/version-1...version-2

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

niro1987 avatar Oct 22 '22 12:10 niro1987

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (verisure) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of verisure can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign verisure Removes the current integration label and assignees on the issue, add the integration domain after the command.

home-assistant[bot] avatar Oct 22 '22 12:10 home-assistant[bot]

Thanks for the PR @niro1987! Looks promising 👀

Will look at it and put it to the test as soon as possible!

../Frenck

frenck avatar Oct 22 '22 22:10 frenck

@frenck can you please advise what to do on the last open review item above?

niro1987 avatar Nov 17 '22 20:11 niro1987

@frenck What is required to proceed?

niro1987 avatar Dec 31 '22 09:12 niro1987

@niro1987 We are awaiting the resolving of the open review comments.

frenck avatar Dec 31 '22 11:12 frenck

@niro1987 Why did you close this PR?

frenck avatar Jan 25 '23 16:01 frenck