core icon indicating copy to clipboard operation
core copied to clipboard

Replace new PRECIPITATION_INTENSITY with enum

Open epenet opened this issue 3 years ago • 2 comments

Proposed change

Linked to https://github.com/home-assistant/architecture/discussions/810#discussioncomment-3921368

Alternative to #80872

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/developers.home-assistant/pull/1489

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

epenet avatar Oct 20 '22 06:10 epenet

Can you please, please 🙏 stop spawning PRs and let finish discussions first.

frenck avatar Oct 20 '22 06:10 frenck

I am marking this as ready for review.

Since the PRECIPITATION_INTENSITY_*** units were not present in 2022.10, I think that we should remove them before beta.

If there is no desire to have enums, we can revert to use the old constants: PRECIPITATION_MILLIMETERS_PER_HOUR, PRECIPITATION_INCHES_PER_HOUR, SPEED_MILLIMETERS_PER_DAY and SPEED_INCHES_PER_DAY (see #80872)

epenet avatar Oct 24 '22 07:10 epenet

Thanks 🙇

epenet avatar Oct 25 '22 14:10 epenet