core icon indicating copy to clipboard operation
core copied to clipboard

Add dynamic unit of measurement support for Overkiz sensor

Open tetienne opened this issue 3 years ago • 2 comments

Breaking change

Proposed change

Until now we hardcoded the unit of measurement. Thanks to this modification, we now read the value from Overkiz when exposed. To avoid any regression, I’ve added the existing unit as default value.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #80284
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

tetienne avatar Oct 17 '22 20:10 tetienne

Hey there @imicknl, @vlebourl, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

home-assistant[bot] avatar Oct 17 '22 20:10 home-assistant[bot]

@Quentame All green now :)

tetienne avatar Nov 07 '22 09:11 tetienne

@Quentame Have you any Overkiz sensors? I tested locally with my Atlantic solution, but obviously it does not cover all the cases.

tetienne avatar Feb 01 '23 21:02 tetienne

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 28 '23 07:02 home-assistant[bot]

@epenet About the your unit comments, it’s ok if I do it myself in another PR or do you prefer someone from the Core team?

tetienne avatar Mar 01 '23 09:03 tetienne

@epenet About the your unit comments, it’s ok if I do it myself in another PR or do you prefer someone from the Core team?

I think it's better if you do it (in two separate PRs - one for flow, one for concentration)

epenet avatar Mar 01 '23 10:03 epenet

LGTM 👍 @iMicknl anything else to add?

Looks good! Happy with this PR :)

iMicknl avatar Mar 01 '23 12:03 iMicknl