core icon indicating copy to clipboard operation
core copied to clipboard

Add Adguard Home list_type to add/remove url services

Open gieljnssns opened this issue 3 years ago • 6 comments

Breaking change

Proposed change

I have added an list_type flag to add_url and remove_url with a default of blocklist. When you add allowlist you can add and remove allowlists to your Adguard Home.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/24504

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

gieljnssns avatar Oct 11 '22 00:10 gieljnssns

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (adguard) you are listed as a code owner for? Thanks!

homeassistant avatar Oct 11 '22 00:10 homeassistant

Is it really needed to make a breaking change?

frenck avatar Oct 11 '22 07:10 frenck

Maybe it is better to add allowlist to the schema, with default value False.

epenet avatar Oct 11 '22 08:10 epenet

I won't maybe even not make it allowlist but maybe list_type or something, so it is more flexible and not limited to just block/allow (whatever the future may behold).

frenck avatar Oct 11 '22 11:10 frenck

I have removed the breaking change and added list_type

gieljnssns avatar Oct 19 '22 23:10 gieljnssns

Is there something else needed to get this merged?

gieljnssns avatar Nov 07 '22 17:11 gieljnssns

@frenck I'm sorry to call you like this. But do I have to do something else to get this merged?

gieljnssns avatar Nov 20 '22 14:11 gieljnssns

Haven't looked at it again at this point: so can't answer that question. Please have some patience. Thanks

frenck avatar Nov 20 '22 14:11 frenck

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Mar 25 '23 23:03 github-actions[bot]

I'm still waiting for a review...

gieljnssns avatar Mar 27 '23 15:03 gieljnssns

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 07 '23 14:08 home-assistant[bot]