Handle Islamic Prayer Times DST changes

[imiro]

Draft for handling Islamic Prayer Times DST changes #68095 Opening an early PR for feedback from the community. The changes here should be enough to fix the issue, ~~but I haven't completed the tests.~~

Proposed change

Set Islamic Prayer Times sensor updates to happen on 02:01 AM instead of midnight each day, as discussed on #68095

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #68095
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] The code has been formatted using Black (black --fast homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• [ ] No score or internal
• [ ] 🥈 Silver
• [ ] 🥇 Gold
• [ ] 🏆 Platinum

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[homeassistant]

Hi imiro

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[homeassistant]

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (islamic_prayer_times) you are listed as a code owner for? Thanks!

[imiro]

Hi @homeassistant I'm new to contributing here, is there anything else I need to do to have this merged?

[B0ndo2]

The fix didn't work. DST changed back at 2AM today

[imiro]

Yes, I’m aware of it too. It appears I didn’t dig deep enough and didn’t test the code properly. I have investigated the cause and will get back on a short write-up on the issue thread.

On Sun, Nov 6, 2022 at 9:32 AM B0ndo2 @.***> wrote:

The fix didn't work. DST changed back at 2AM today

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/79881#issuecomment-1304827152, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDENO7IFI5UD2K4XXGDCHDWG66QBANCNFSM6AAAAAARAJD4OM . You are receiving this because you authored the thread.Message ID: @.***>

[frenck]

Considering the above comment, I've marked the PR as a draft for now.

@imiro Are you planning on picking up this PR and moving it forward?

../Frenck

[imiro]

Hi @frenck, yeah I'm currently waiting for a PR in the prayer_times_calculator package as a dependency of this issue to be merged. Once it's merged I'd be able to move forward

[frenck]

Awesome, thanks for the update 👍

../Frenck

[imiro]

I believe this PR is no longer needed. The upstream API from which this component fetch data has fixed the underlying issue which should solve https://github.com/home-assistant/core/issues/68095 as well. My manual test somewhat confirmed it, but we should be able to confirm when the DST change happens again this weekend. I'm thinking to add a test case just to be sure, but not sure how to since it will have to make an API call.

[imiro]

Confirmed that the upstream API has solved the issue thus this PR is no longer needed.