core icon indicating copy to clipboard operation
core copied to clipboard

Add device registration to the Nuki component

Open pree opened this issue 2 years ago • 3 comments

Proposed change

Introduces device registrations for the Nuki entities, including the bridge.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes https://github.com/home-assistant/home-assistant.io/issues/24068

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

pree avatar Oct 07 '22 12:10 pree

Hey there @pschmitt, @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (nuki) you are listed as a code owner for? Thanks!

homeassistant avatar Oct 07 '22 12:10 homeassistant

Anything missing for this PR to be reviewed?

pree avatar Oct 22 '22 16:10 pree

Also the fact this PR is not being reviewed prevents the Nuki integration to have new entity naming style (#80021 )

Nardol avatar Oct 27 '22 07:10 Nardol

@pree can you rebase it, so I can merge it?

pvizeli avatar Jan 25 '23 12:01 pvizeli

@pvizeli rebased

pree avatar Jan 25 '23 14:01 pree