core icon indicating copy to clipboard operation
core copied to clipboard

Add nibe heat pump climate entities

Open elupus opened this issue 1 year ago • 2 comments

Proposed change

Add nibe heat pump climate entities

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/24141

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

elupus avatar Sep 22 '22 13:09 elupus

@yozik04 just looked on s series modbus: https://www.google.com/url?sa=t&source=web&rct=j&url=https://www.nibe.eu/download/18.3db69dc1795e0d992c5722/1622634529178/Modbus%2520S-series%2520EN%2520M12676EN-1.pdf&ved=2ahUKEwj2uMzFkbz6AhUzRvEDHWrxCagQFnoECBQQAQ&usg=AOvVaw3PBdJdOiSxa-2ygr15j6NO

Annoyingly the numbering does not line up with F series. Even if you add the 40000 prefix for holding register.

So this setup will work fine for F series pumps, but once we add support for S series pumps, we need other numbers.

I think we need some database for this in the backing lib eventually.

elupus avatar Sep 30 '22 08:09 elupus

Ahh. Can be. I though "Type of register" is a prefix.

yozik04 avatar Sep 30 '22 08:09 yozik04