core icon indicating copy to clipboard operation
core copied to clipboard

Move MQTT discovery hass.data globals to dataclass

Open jbouwh opened this issue 2 years ago • 2 comments

Proposed change

Move the hass.data[] globals ALREADY_DISCOVERED, PENDING_DISCOVERED, DATA_CONFIG_FLOW_LOCK, DISCOVERY_UNSUBSCRIBE, INTEGRATION_UNSUBSCRIBE to the MqttData class.

This is a follow-up PR on #77972

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

jbouwh avatar Sep 18 '22 18:09 jbouwh

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

This PR is related: https://github.com/home-assistant/core/pull/78825

jbouwh avatar Sep 20 '22 13:09 jbouwh

@epenet would you mind to have a look here as well?

jbouwh avatar Sep 22 '22 14:09 jbouwh