core icon indicating copy to clipboard operation
core copied to clipboard

Fully Kiosk Browser integration card isn't showing device names

Open ktownsend-personal opened this issue 2 years ago • 5 comments

The problem

I have added multiple tablets to the Fully Kiosk Browser integration, but instead of showing the names of my tablets (I renamed the devices after adding them), the integration card just calls them all the same thing (Fire Tablet), so I can't tell which one I'm trying to click into. Other integration cards show actual device name, which is much easier to use.

What version of Home Assistant Core has the issue?

2022.9.0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Fully Kiosk Browser

Link to integration documentation on our website

https://www.home-assistant.io/integrations/fully_kiosk

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

ktownsend-personal avatar Sep 07 '22 19:09 ktownsend-personal

Hey there @cgarwood, mind taking a look at this issue as it has been labeled with an integration (fully_kiosk) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

Same Problem here without a name for each of two tablets and if I rename one the name goes to both. I think this is related and/or causing #77722 as well

I cannot change either device or integration name nor control separately unfortunately so need to go back to HACS version to have things work for now

tonysurma avatar Sep 10 '22 18:09 tonysurma

@tonysurma, I'm not having a merge issue. The problem in this ticket is just the names I have assigned are not shown in the integration card; it just shows "Fire Tablet" four times and I have to click into each one to find the one I want. The real device names that I configured are "Lounge Tablet", "Utility Tablet", etc.

ktownsend-personal avatar Sep 12 '22 02:09 ktownsend-personal

I did some poking around in core.device_registry and noticed there are two properties for the name:

        "name_by_user": "Master Suite Tablet",
        "name": "Fire Tablet",

I suspect the integration needs to use name_by_user when it exists instead of name.

ktownsend-personal avatar Oct 24 '22 16:10 ktownsend-personal

Any chance this can be addressed?

ktownsend-personal avatar Dec 14 '22 20:12 ktownsend-personal

When you say Integration Card are you referring to the card on the Settings -> Devices & Services page? If so, that's all handled by the HA core, not the fully_kiosk integration.

You mention renaming the device, there's a separate rename button for the integration, which I believe is what shows up on that Integrations page. Make sure you rename the integration as well.

cgarwood avatar Jan 06 '23 03:01 cgarwood

That's interesting. Either I didn't see that option to rename items within the integration card, or it's new since I initially had the issue. Either way, I see that it updates the name in .storage/core.config_entries rather than the other file I found names for these devices .storage/core.device_registry. It isn't intuitive to have the names used by the integration separate from the names of the devices since they represent the exact same device...I wonder why it was designed that way?

ktownsend-personal avatar Jan 06 '23 21:01 ktownsend-personal

@ktownsend-personal When you go to Settings | Integrations, you're not looking at "devices", you're looking at configurations. The configuration can be renamed. One configuration in Home Assistant can map to 0 or more devices. If a given configuration produces multiple devices, each of the devices can be renamed by the user. So, to me at least, it doesn't make sense that renaming the configuration would also rename the device.

Look at the Sun configuration as an example. There's no device associated with it but you can still rename the configuration. The entity associated with that configuration is still sun.sun.

The Synology integration is on the opposite end of the spectrum. My single Synology configuration produces 12 devices in Home Assistant. If I were to rename the Synology configuration, I wouldn't expect all the devices to get renamed.

I hope this clarifies things. Regardless, it seems to me that this is out of the scope of the Fully Kiosk Browser integration. If you think there's still a problem please let us know, otherwise could you please close the issue?

mheath avatar Feb 23 '23 05:02 mheath

Thanks for explaining the nuances. I'll close this ticket. It's still not intuitive to a user so I would say there is room for simplification someplace or automatic sync on the names when they happen to be 1 to 1 mapped. I understand it's probably outside your scope but I wanted to relay the feedback to someone familiar with it.

ktownsend-personal avatar Feb 24 '23 17:02 ktownsend-personal