core icon indicating copy to clipboard operation
core copied to clipboard

Add Whirlpool washer and dryer to Whirlpool integration

Open mkmer opened this issue 2 years ago • 3 comments

Proposed change

Addition of Sensor platform for the washer/dryer appliances.
State sensor and time_remaining sensors are created under a device for each washer/dryer found in the users account. Existing Sixth Sense climate now supports device.

Depends on https://github.com/home-assistant/core/pull/77237

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: #24107

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

mkmer avatar Aug 26 '22 01:08 mkmer

Hey there @abmantis, mind taking a look at this pull request as it has been labeled with an integration (whirlpool) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

Lets keep this as draft before the other region PR gets in to avoid having reviewers reviewing twice the same thing.

abmantis avatar Aug 28 '22 10:08 abmantis

A draft it is.

mkmer avatar Aug 28 '22 18:08 mkmer

Branch messed up.. creating new PR

mkmer avatar Dec 30 '22 14:12 mkmer