core
core copied to clipboard
Wallbox switch entity state incorrect while discharging
Proposed change
Bug fix to functionality recently introduced to the Wallbox integration adding support for bidirectional chargers. This PR fixes an issue where the switch state is not available/incorrect while discharging.
Type of change
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] The code has been formatted using Black (
black --fast homeassistant tests
) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
The integration reached or maintains the following Integration Quality Scale:
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @hesselonline, mind taking a look at this pull request as it has been labeled with an integration (wallbox
) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)
@hesselonline can you let me know what else I need to do with this to get it moving into the next release please?
@simeon-simsoft you need a review by a core member of the hass team, afterwards he can approve and merge the change. Maybe ask the person who approved your last PR for a review?
@epenet Would you mind reviewing this please.. its a fix to a previous PR that you were kind enough to review and merge.
Thanks