core icon indicating copy to clipboard operation
core copied to clipboard

Always round down for Mazda odometer entity

Open bdr99 opened this issue 3 years ago • 3 comments

Proposed change

Adjust the behavior of the Mazda odometer entity so that it always rounds down, instead of rounding to the nearest integer. This is to better match the behavior of the Mazda vehicles and mobile app.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes https://github.com/home-assistant/core/issues/76421
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [x] 🏆 Platinum

To help with the load of incoming pull requests:

bdr99 avatar Aug 09 '22 01:08 bdr99

Only minor suggestion would be to add a comment saying that you are doing it this way to match the behaviour of the app.

davet2001 avatar Aug 09 '22 06:08 davet2001

Thanks a lot for your fast support. It was not a problem, but it's "more logical" to have the exact same values in car, mazda app and HA

it-luisfsb avatar Aug 09 '22 09:08 it-luisfsb

@davet2001 Thanks, agreed. I added a comment.

bdr99 avatar Aug 09 '22 13:08 bdr99