core icon indicating copy to clipboard operation
core copied to clipboard

Add Synchronize inverter clock button

Open mletenay opened this issue 3 years ago • 3 comments

Proposed change

Add Synchronize inverter clock button to device config section. Most of the PV inverters do not update their internal clock automatically when DST change happens. Expose new button as config entity which synchronizes internal inverter clock with the HA system time

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description. [https://github.com/marcelblijleven/goodwe/releases]
  • [x] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [x] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

mletenay avatar Apr 03 '22 21:04 mletenay

Hey there @starkillerog, mind taking a look at this pull request as it has been labeled with an integration (goodwe) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar May 03 '22 21:05 github-actions[bot]

@starkillerOG or anyone else, would you mind taking a look and review ? Thanks.

mletenay avatar May 05 '22 09:05 mletenay