core icon indicating copy to clipboard operation
core copied to clipboard

Radarr config flow

Open tkdrob opened this issue 3 years ago • 3 comments

Breaking change

Radarr can now be set up in the UI. Existing yaml configurations are automatically imported and can be safely removed.

Some breaking changes has been made in disabling the Movies count sensor out of caution. This sensor can cause problems with massive databases. If the user still wishes to use it, they may do so. Movie names are no longer included as attributes in the movies sensor. Upcoming has been removed. It is being modernized as calendar items should be. Diskspace is now split into different sensors, one for each folder. Status and commands have been removed as they don't appear to have real value for automations.

Proposed change

Add config flow to radarr integration

dependency repo: https://github.com/tkdrob/aiopyarr This PR depends on https://github.com/home-assistant/core/pull/66411

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/20550

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

tkdrob avatar Mar 23 '22 00:03 tkdrob

Tests pass locally

tkdrob avatar Apr 08 '22 12:04 tkdrob

Status has also been removed as it does not appear to be useful. An update entity should be done in the future instead.

tkdrob avatar May 22 '22 16:05 tkdrob

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 05 '22 18:09 github-actions[bot]

merging this as it's not going into dev. The branch will need to be rebased and fixed before it can be merged.

balloob avatar Sep 22 '22 00:09 balloob