core icon indicating copy to clipboard operation
core copied to clipboard

Add new Rabbit Air integration

Open al-s opened this issue 3 years ago • 10 comments

Proposed change

Add new integration for Rabbit Air air purifiers.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/21560

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [x] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

al-s avatar Feb 09 '22 00:02 al-s

Hello @al-s,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting Author Name and [email protected] for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! :heart:

homeassistant avatar Feb 09 '22 00:02 homeassistant

Hi @al-s,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant avatar Feb 09 '22 22:02 homeassistant

Bump :) Would love to see this merged

michaelkkehoe avatar Oct 03 '22 22:10 michaelkkehoe

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jan 15 '23 22:01 github-actions[bot]

@al-s Bump. Is this still being worked on?

michaelkkehoe avatar Mar 27 '23 05:03 michaelkkehoe

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 07 '23 07:08 home-assistant[bot]

@al-s I've seen you taking action on the last comment by @edenhaus, but.. conversations have not been marked as resolved and this PR is currently still in draft. Are you still working on it?

../Frenck

frenck avatar Oct 06 '23 09:10 frenck

@frenck @edenhaus Thanks for your attention to this PR! It's been a while since I wrote this code and I wanted to recheck that everything still works fine, but had no time for it. I'll try to do it in the next few days.

al-s avatar Oct 09 '23 03:10 al-s

Is there anything I can contribute/review to this to speed this integration's merge faster? I only have RabbitAir purifiers in my house, and this would help me. :D

neumachen avatar Oct 22 '23 14:10 neumachen

The PR is still in draft and, therefore, considered in progress and not ready for another review. The author can mark it as ready for review when he thinks it is ready.

Is there anything I can contribute/review to this to speed this integration's merge faster? I only have RabbitAir purifiers in my house, and this would help me. :D

Yes sure. You can review other PR's to bring the number of PR's down :) Less open PR's means we can come back to this one quicker :)

edenhaus avatar Oct 23 '23 08:10 edenhaus