Fix Mill set_climate ignoring HVAC mode

[ShadowJonathan]

Fixes #155413

Proposed change

Fix Mill set_temperature ignoring HVAC mode argument.

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: Fixes #155413

• Move shared HVAC setting logic to _do_set_hvac_mode

Checklist

• [x] I understand the code I am submitting and can explain how it works.
• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Ruff (ruff format homeassistant tests)
• [x] Tests have been added to verify that the new code works.
• [x] Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• [x] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (mill) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mill can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign mill Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[ShadowJonathan]

Codecov doesn't like that I'm editing code for an integration that doesn't have a test suite.

I don't know how to create one for this integration.

[ShadowJonathan]

@Danielhiversen could you help me some with creating some test suite/coverage for this integration?

The PR itself should be fine, but apparently it doesn't like it when I make changes without a test suite.

[Danielhiversen]

You can add a test here: https://github.com/home-assistant/core/tree/dev/tests/components/mill

[frenck]

I've marked this PR a draft, as changes are requested that need to be processed. Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

Learn more about our pull request process.

[ShadowJonathan]

I added some tests, and now the code coverage is showing 100% patch diff hit.

However, I'm not 100% happy with how I created the tests, but I also don't know how I can improve this. If there's a better way to do this, please give me some examples that can improve it.

Or else, if this is all good, then it can "just" get merged.

cc @Danielhiversen, @frenck

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[ShadowJonathan]

@MartinHjelmare I've changed over the testing method(s) to use service calls and entry configuration instead, please tell me if this looks alright or not.

[ShadowJonathan]

I've parameterised it entirely down to 2 test functions; I'm not sure if the size of the parameters i'm giving it is too large or not, but I'm pretty happy with this.