core icon indicating copy to clipboard operation
core copied to clipboard

Set quality scale to 🥇 gold for switchbot integration

Open zerzhang opened this issue 7 months ago • 4 comments

Breaking change

Proposed change

set quality scale to 🥇 gold for switchbot integration

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

zerzhang avatar May 10 '25 09:05 zerzhang

Hey there @danielhiversen, @renierm26, @murtas, @eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar May 10 '25 09:05 home-assistant[bot]

Hey, looking at the criteria for "silver" one of them is an active code owner but I haven't seen much activity for the last few months from the owners of this integration: https://github.com/home-assistant/core/labels/integration%3A%20switchbot

Has one or more active code owners who help maintain the integration.

How do we define active here wrt the open issues?

Samywamy10 avatar May 12 '25 07:05 Samywamy10

I have set myself as the code owner

zerzhang avatar May 12 '25 09:05 zerzhang

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 12 '25 13:05 home-assistant[bot]

exception translations

@joostlek I have add execption translations for device init in https://github.com/home-assistant/core/pull/144828, but the unit test works fail, Could you help to have a look?

zerzhang avatar May 13 '25 13:05 zerzhang

Hey, looking at the criteria for "silver" one of them is an active code owner but I haven't seen much activity for the last few months from the owners of this integration: integration: switchbot

Has one or more active code owners who help maintain the integration.

How do we define active here wrt the open issues?

@Samywamy10 Hi this is Davidson from the SwitchBot team. I myself is maintaining our OpenAPI repo and @zerzhang is the code owner now responsible for Home Assistant Bluetooth integration. We are the point of contacts from this point. You can assign issues to us and we will look into them as soon as possible.

Minsheng avatar May 20 '25 02:05 Minsheng

@Minsheng there are quite a lot of open issues: https://github.com/home-assistant/core/labels/integration%3A%20switchbot

In particular this one is affecting me and a few other people: https://github.com/home-assistant/core/issues/142316

I don't have permissions to assign issues but you should be able to see all the open issues at that link above

Samywamy10 avatar May 20 '25 03:05 Samywamy10

@Minsheng there are quite a lot of open issues: integration: switchbot

In particular this one is affecting me and a few other people: #142316

I don't have permissions to assign issues but you should be able to see all the open issues at that link above

I've replied to this issue and we will keep an eye on it.

Minsheng avatar May 23 '25 06:05 Minsheng

Removed from the patch milestone. I assume this was an error.

frenck avatar May 23 '25 13:05 frenck

Removed from the patch milestone. I assume this was an error.

Yes it was, it was meant for the beta milestone

joostlek avatar May 26 '25 13:05 joostlek