core icon indicating copy to clipboard operation
core copied to clipboard

Add nanoleaf effect icons

Open S33G opened this issue 8 months ago • 5 comments

Proposed change

Add effect icons to Nanoleaf component

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

S33G avatar May 09 '25 09:05 S33G

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 09 '25 09:05 home-assistant[bot]

Hey there @milanmeu, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (nanoleaf) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nanoleaf can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nanoleaf Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar May 09 '25 09:05 home-assistant[bot]

So it also makes me wonder, are the effects a limited set?

No, you can create your own effects, and change default effects in the Nanoleaf app including changing the name and deleting them.

milanmeu avatar May 09 '25 10:05 milanmeu

Right, I was just discussing this with s33g in a call on discord (that's how this PR came to be in the first place), and I do think we can look at the default set of effects to get icons and translations

joostlek avatar May 09 '25 10:05 joostlek

So it also makes me wonder, are the effects a limited set?

No, you can create your own effects, and change default effects in the Nanoleaf app including changing the name and deleting them.

Yeah I've since tested this. I'll do some testing later, thanks for @joostlek for the advice.

S33G avatar May 09 '25 11:05 S33G

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Jul 14 '25 15:07 github-actions[bot]