core icon indicating copy to clipboard operation
core copied to clipboard

Bump Roborock Map Parser to 0.1.4

Open Lash-L opened this issue 8 months ago • 1 comments

Breaking change

The big change here is that some of the drawing logic is very optimized now. On some devices with low ram, our update to increase the maps resolution was causing crashes, this fixes it. Should be included in beta if possible!

Library change: https://github.com/PiotrMachowski/Python-package-vacuum-map-parser-roborock/compare/v0.1.2...v0.1.4 Which is based off of: https://github.com/PiotrMachowski/Python-package-vacuum-map-parser-base/compare/v0.1.3...v0.1.5

Proposed change

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #143105
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Lash-L avatar May 05 '25 13:05 Lash-L

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar May 05 '25 13:05 home-assistant[bot]

Does this decrease resolution of the objects like the robot on the map?

allenporter avatar May 05 '25 14:05 allenporter

Does this decrease resolution of the objects like the robot on the map?

It should not! My testing shows the maps looking identical - but if you would like to double check that would be helpful!

Lash-L avatar May 05 '25 14:05 Lash-L

Does this decrease resolution of the objects like the robot on the map?

It should not! My testing shows the maps looking identical - but if you would like to double check that would be helpful!

Thanks for confirming. I can test in beta also. I think its important to get this memory fix out so appreciate it.

allenporter avatar May 05 '25 14:05 allenporter