home-assistant
Daikin br integration
Breaking change
Proposed change
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [X] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/38064
- Link to developer documentation pull request:
- Link to frontend pull request:
Checklist
- [X] The code change is tested and works locally.
- [X] Local tests pass. Your PR cannot be merged unless tests pass
- [X] There is no commented out code in this PR.
- [X] I have followed the development checklist
- [X] I have followed the perfect PR recommendations
- [X] The code has been formatted using Ruff (
ruff format homeassistant tests) - [X] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [X] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [X] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [X] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Learn more about our pull request process.
![home-assistant[bot] avatar](https://avatars.githubusercontent.com/in/97978?v=4 "Published by a pub.dev verified publisher"){kind=small}
Although the integration being developed is generic for Smart Split AC models using the 3P547864-3H/RZ-093 series of Wi-Fi adaptors, this solution is currently being rolled out by Daikin in Brazil. It may be expanded to other regions in the future. As the rollout extends, the codebase and documentation will be updated accordingly.
So should we make the name more specific to the device/subject than just daikin-br if in the future its not only Brasil?
This solution will work only for daikin products. daikin_br domain is generic -- br stands for Based on Region. Though BR happens to be an acronym of Brazil also.
On Sat, 22 Mar 2025 at 16:15, Joost Lekkerkerker @.***> wrote:
So should we make the name more specific to the device/subject than just daikin-br if in the future its not only Brasil?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745207237, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ6AHZ4BLGRJRCNAPQ32VU5ODAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYDOMRTG4 . You are receiving this because you were mentioned.Message ID: @.***> [image: joostlek]joostlek left a comment (home-assistant/core#140854) https://github.com/home-assistant/core/pull/140854#issuecomment-2745207237
So should we make the name more specific to the device/subject than just daikin-br if in the future its not only Brasil?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745207237, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ6AHZ4BLGRJRCNAPQ32VU5ODAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYDOMRTG4 . You are receiving this because you were mentioned.Message ID: @.***>
But why don't we pick a term that is related to the product instead of the place of availability?
Ok, I understand your point. Since the application/product is for air conditioners, can the domain be set as daikin_ac? Let me know if this works, or feel free to suggest alternatives.
On Sat, 22 Mar 2025 at 16:36, Joost Lekkerkerker @.***> wrote:
But why don't we pick a term that is related to the product instead of the place of availability?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745213519, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ7RN7HRW7SD6EHTJH32VU72TAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYTGNJRHE . You are receiving this because you were mentioned.Message ID: @.***> [image: joostlek]joostlek left a comment (home-assistant/core#140854) https://github.com/home-assistant/core/pull/140854#issuecomment-2745213519
But why don't we pick a term that is related to the product instead of the place of availability?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745213519, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ7RN7HRW7SD6EHTJH32VU72TAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYTGNJRHE . You are receiving this because you were mentioned.Message ID: @.***>
I am mostly wondering what this product exactly is, as in, we already have a daikin integration, what's the difference between that integration and this? And, there's daikin_onecta, which is a cloud based product, is that also different from this?
Yes, this product is entirely different from the one currently published. The already published ones are using different protocols and different model types.
On Sat, 22 Mar 2025 at 16:45, Joost Lekkerkerker @.***> wrote:
I am mostly wondering what this product exactly is, as in, we already have a daikin integration, what's the difference between that integration and this? And, there's daikin_onecta, which is a cloud based product, is that also different from this?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745216316, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ2EWMHTE34O4WL2K4D2VVA5VAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYTMMZRGY . You are receiving this because you were mentioned.Message ID: @.***> [image: joostlek]joostlek left a comment (home-assistant/core#140854) https://github.com/home-assistant/core/pull/140854#issuecomment-2745216316
I am mostly wondering what this product exactly is, as in, we already have a daikin integration, what's the difference between that integration and this? And, there's daikin_onecta, which is a cloud based product, is that also different from this?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745216316, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ2EWMHTE34O4WL2K4D2VVA5VAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYTMMZRGY . You are receiving this because you were mentioned.Message ID: @.***>
But can you elaborate a bit more in depth on that, how do they differ from this?
This solution is only applicable for Split AC models (Mostly for home/residential usage). This solution is currently deployed in Brasil. Plan is to deploy in some regions in Asia also. I do not have much technical insight into other solutions as they were developed earlier and are mostly used in EU and US regions. The Mobile Apps and hardware are entirely different in both the solutions.
On Sat, 22 Mar 2025 at 16:52, Joost Lekkerkerker @.***> wrote:
But can you elaborate a bit more in depth on that, how do they differ from this?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745218687, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ6CLGNVUUKYNTS24VL2VVBYHAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYTQNRYG4 . You are receiving this because you were mentioned.Message ID: @.***> [image: joostlek]joostlek left a comment (home-assistant/core#140854) https://github.com/home-assistant/core/pull/140854#issuecomment-2745218687
But can you elaborate a bit more in depth on that, how do they differ from this?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2745218687, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ6CLGNVUUKYNTS24VL2VVBYHAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGIYTQNRYG4 . You are receiving this because you were mentioned.Message ID: @.***>
I suggest that we integrate this into the pydaikin library then we only have one (or perhaps two) Daikin integrations in HomeAssisant and the library take care of the model specific changes.
@daikin-br do you have more insights on which models Daikin are releasing and the different protocols used?
Ok, but this will also require changes to the existing Daikin integration codebase to integrate daikin_br—including updates to files such as entity.py, climate.py, coordinator.py, config_flow.py, and others. I'm not sure how much time this will take or the overall rework involved.
This solution is designed for Split AC systems, which are primarily used for residential purposes. It is currently being rolled out in Brazil and may expand to other regions in the future, though there is no clarity on that yet.
Would it be a significant challenge to keep these codebases or integrations separate within Home Assistant?
On Sun, 23 Mar 2025 at 10:55, Fredrik Erlandsson @.***> wrote:
I suggest that we integrate this into the pydaikin library then we only have one (or perhaps two) Daikin integrations in HomeAssisant and the library take care of the model specific changes.
@daikin-br https://github.com/daikin-br do you have more insights on which models Daikin are releasing and the different protocols used?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2746030336, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZZ27F5QK5NPGJTYWX32VZAUBAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGAZTAMZTGY . You are receiving this because you were mentioned.Message ID: @.***> [image: fredrike]fredrike left a comment (home-assistant/core#140854) https://github.com/home-assistant/core/pull/140854#issuecomment-2746030336
I suggest that we integrate this into the pydaikin library then we only have one (or perhaps two) Daikin integrations in HomeAssisant and the library take care of the model specific changes.
@daikin-br https://github.com/daikin-br do you have more insights on which models Daikin are releasing and the different protocols used?
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2746030336, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZZ27F5QK5NPGJTYWX32VZAUBAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGAZTAMZTGY . You are receiving this because you were mentioned.Message ID: @.***>
Ok, but this will also require changes to the existing Daikin integration codebase to integrate daikin_br—including updates to files such as entity.py, climate.py, coordinator.py, config_flow.py, and others. I'm not sure how much time this will take or the overall rework involved. This solution is designed for Split AC systems, which are primarily used for residential purposes. It is currently being rolled out in Brazil and may expand to other regions in the future, though there is no clarity on that yet. Would it be a significant challenge to keep these codebases or integrations separate within Home Assistant?
The device specifics in climate.py needs to be moved from the ha-code into an underlying module anyway so I think the best is if we move all of this into pydaikin (which already supports 4-5 different models of both split and fully integrated Daikin systems).
p.s. Don't reply on github emails, it looks awful 😉
Thanks for your feedback. My understanding was that -- the communication related code needs to be part of the library package. I was not aware that it is mandatory to keep the device specific like temp range checks, mode mapping etc also in the library package. I will work on these suggestions.
Are you suggesting to merge only the daikin_br library package into pydaikin or merging daikin_br integration with daikin as well?
On Sun, 23 Mar 2025 at 12:19, Fredrik Erlandsson @.***> wrote:
Ok, but this will also require changes to the existing Daikin integration codebase to integrate daikin_br—including updates to files such as entity.py, climate.py, coordinator.py, config_flow.py, and others. I'm not sure how much time this will take or the overall rework involved. This solution is designed for Split AC systems, which are primarily used for residential purposes. It is currently being rolled out in Brazil and may expand to other regions in the future, though there is no clarity on that yet. Would it be a significant challenge to keep these codebases or integrations separate within Home Assistant?
The device specifics in climate.py needs to be moved from the ha-code into an underlying module anyway so I think the best is if we move all of this into pydaikin (which already supports 4-5 different models of both split and fully integrated Daikin systems).
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2746055937, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ7DOYD7D7ZMB2YOKRD2VZKOBAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGA2TKOJTG4 . You are receiving this because you were mentioned.Message ID: @.***> [image: fredrike]fredrike left a comment (home-assistant/core#140854) https://github.com/home-assistant/core/pull/140854#issuecomment-2746055937
Ok, but this will also require changes to the existing Daikin integration codebase to integrate daikin_br—including updates to files such as entity.py, climate.py, coordinator.py, config_flow.py, and others. I'm not sure how much time this will take or the overall rework involved. This solution is designed for Split AC systems, which are primarily used for residential purposes. It is currently being rolled out in Brazil and may expand to other regions in the future, though there is no clarity on that yet. Would it be a significant challenge to keep these codebases or integrations separate within Home Assistant?
The device specifics in climate.py needs to be moved from the ha-code into an underlying module anyway so I think the best is if we move all of this into pydaikin (which already supports 4-5 different models of both split and fully integrated Daikin systems).
— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/140854#issuecomment-2746055937, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ7DOYD7D7ZMB2YOKRD2VZKOBAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGA2TKOJTG4 . You are receiving this because you were mentioned.Message ID: @.***>
Thanks for your feedback. My understanding was that -- the communication related code needs to be part of the library package. I was not aware that it is mandatory to keep the device specific like temp range checks, mode mapping etc also in the library package. I will work on these suggestions.
The whole idea is that ha should not know about specifics for units.
Are you suggesting to merge only the daikin_br library package into pydaikin or merging daikin_br integration with daikin as well? …
Everything should be merged with pydaikin. I'll help with a review there. This will be a new class that inherent from base.py, then everything will work almost automatically on ha-side. We just need to add another field for the Daikin-br key in the setup and update the discovery code.
On Sun, 23 Mar 2025 at 12:19, Fredrik Erlandsson @.> wrote: Ok, but this will also require changes to the existing Daikin integration codebase to integrate daikin_br—including updates to files such as entity.py, climate.py, coordinator.py, config_flow.py, and others. I'm not sure how much time this will take or the overall rework involved. This solution is designed for Split AC systems, which are primarily used for residential purposes. It is currently being rolled out in Brazil and may expand to other regions in the future, though there is no clarity on that yet. Would it be a significant challenge to keep these codebases or integrations separate within Home Assistant? The device specifics in climate.py needs to be moved from the ha-code into an underlying module anyway so I think the best is if we move all of this into pydaikin (which already supports 4-5 different models of both split and fully integrated Daikin systems). — Reply to this email directly, view it on GitHub <#140854 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ7DOYD7D7ZMB2YOKRD2VZKOBAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGA2TKOJTG4 . You are receiving this because you were mentioned.Message ID: @.> [image: fredrike]fredrike left a comment (home-assistant/core#140854) <#140854 (comment)> Ok, but this will also require changes to the existing Daikin integration codebase to integrate daikin_br—including updates to files such as entity.py, climate.py, coordinator.py, config_flow.py, and others. I'm not sure how much time this will take or the overall rework involved. This solution is designed for Split AC systems, which are primarily used for residential purposes. It is currently being rolled out in Brazil and may expand to other regions in the future, though there is no clarity on that yet. Would it be a significant challenge to keep these codebases or integrations separate within Home Assistant? The device specifics in climate.py needs to be moved from the ha-code into an underlying module anyway so I think the best is if we move all of this into pydaikin (which already supports 4-5 different models of both split and fully integrated Daikin systems). — Reply to this email directly, view it on GitHub <#140854 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BP2IGZ7DOYD7D7ZMB2YOKRD2VZKOBAVCNFSM6AAAAABZHMYWYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBWGA2TKOJTG4 . You are receiving this because you were mentioned.Message ID: @.***>
Nice with email replies..
I checked with team and unfortunately it is not possible for us to go ahead with this merge / refactoring at this time. Moreover, we anyway have to maintain the pyiotdevice library (irrespective of the merge) as it is being used by other devices as well outside HA.
We can later look at this merge and integration of daikin_br HA code base with daikin.
not possible for us to go ahead with this merge / refactoring at this time.
Why? What team?
We don't want to create a specific integration for every specific model line if it's not needed.
Thanks for your feedback and effort in reviewing this PR.
Merging with pydaikin and the Daikin integration is not feasible for us due to limited availability and effort constraints to understand the codebases and implement the necessary changes.
If @fredrike, as the owner of the pydaikin library and Daikin integration, can merge this integration, we are happy to assist in testing the merged code on a physical device to ensure everything works as expected. Please let us know your thoughts.
What Team? --> the development team that has created this IoT based solution for this product line of the Daikin AC. Why? - I am assuming you are asking why this integration is required? --> We are getting the request from the end users to enable this product on the HA platform. Hence we have developed this integration. Let me know if you need any further details.
Can you please contact Miranda, our partnership manager at [email protected]?
I have sent an email to Miranda.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}