Add matter attributes
Breaking change
Proposed change
Adds entities to set or report on several additional matter attributes:
Basic Information Cluster LocalConfigDisabled (added as a Select entity)
DoorLock Cluster: AutoRelockTimer (added as a Number entity) SoundVolume (added as a Select entity) EnableOneTouchLocking (added as a Select entity) MinPINCodeLength (added as a diagnostics sensor). MaxPINCodeLength (added as a diagnostics sensor).
WindowCovering TargetPositionLiftPercent100ths (added as a diagnostic entity, converted to the % that the shade is open to match the way in which the open/close slider presents the info.)
OccupancySensing PIROccupiedToUnoccupiedDelay (added as a Number entity)
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
- Link to developer documentation pull request:
- Link to frontend pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [ ] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of matter can trigger bot actions by commenting:
@home-assistant closeCloses the pull request.@home-assistant rename Awesome new titleRenames the pull request.@home-assistant reopenReopen the pull request.@home-assistant unassign matterRemoves the current integration label and assignees on the pull request, add the integration domain after the command.@home-assistant add-label needs-more-informationAdd a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.@home-assistant remove-label needs-more-informationRemove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Marking this PR as a draft, as there is a merge conflict.
Could you take a look @jvmahon?
../Frenck
@marcelveldt I think all the issues you flagged in this are now fixed. I removed a number of attributes where you suggested they would be better represented as "switch" entities. I'll add those back in a separate PR.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
@jvmahon sorry for the late feedback. I just noticed that this PR brings in some additional entities which do not belong in the HA state machine:
MinPINCodeLength, MaxPINCodeLength and probably also TargetPositionLiftPercent100ths (I need to double check that). That is just static information - there is no use for it as entity at all and it will only cause "noise" towards users in the UI.
We will remove those again in a follow-up PR. In the future there might be a usecase to knowing this info while setting up a lock code in the HA interface but that is a different discussion and needs a proper architectural discussion first. Adding static info to the state machien is simply not allowed, hence we will reverse it.
EDIT: TargetPositionLiftPercent100ths is an actual sensor but a very advanced one - we try to limit those as much as we can to not overwhelm users. We have a setting to disable such entities by default.
Thanks for understanding.