core icon indicating copy to clipboard operation
core copied to clipboard

Add SMLIGHT sensor entities for second radio

Open tl-sl opened this issue 10 months ago • 7 comments

Proposed change

SMLIGHT are releasing a new device SLZB-MR1 which adds a second Zigbee radio to the SLZB device. This continues on from PR #136918.

Add sensors for second radio:

  • Temperature of second Zigbee chip
  • Firmware type of second Zigbee chip (coordinator, router etc)

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/38147
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

tl-sl avatar Feb 05 '25 06:02 tl-sl

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 05 '25 11:02 home-assistant[bot]

I have fixed merge conflict and CI coverage failure (not sure why this didn't occur with previous PR's that caused it).

@joostlek can you take a look at this again, thanks..

tl-sl avatar Feb 19 '25 23:02 tl-sl

Any chance this can get merged for 2025.3? I also have one more PR to followup on this to finalise second radio support.

tl-sl avatar Feb 28 '25 08:02 tl-sl

Any chance this can get merged for 2025.3? I also have one more PR to followup on this to finalise second radio support.

That isn't possible, 2025.3 beta has already started, meaning it has reached the feature freeze.

frenck avatar Mar 02 '25 20:03 frenck

Hi Frenck, There are no new sensors here as such. It is just creating new instances of the existing sensors but for the second radio. I was planning to add this new device to documentation under supported devices on completion of this series (there is one more PR to come). However right now its not publicly announced or available for purchase which might cause confusion. There are however samples out in the wild with bloggers etc..

tl-sl avatar Mar 03 '25 06:03 tl-sl

I have added a docs PR to this. Seems the CI check for docs-missing is still failing though.

tl-sl avatar Mar 23 '25 00:03 tl-sl

@joostlek @frenck Any chance to get this merged before April release? I have added a docs PR, but its still flagged as missing docs.

tl-sl avatar Mar 25 '25 10:03 tl-sl

Thanks Frenck, Also pushed a small follow up PR making use of the improved radios typing in the update entities.

tl-sl avatar Mar 26 '25 10:03 tl-sl