core icon indicating copy to clipboard operation
core copied to clipboard

Make BT support detection dynamic for Shelly RPC devices

Open chemelli74 opened this issue 10 months ago • 5 comments

Proposed change

Some devices, even if gen2+, has support for BT but not for scripts. With the introduction of XMOD devices, "model" is no more reliable for such detection.

This PR test for the real capability so that is no more linked to a static list of devices.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

chemelli74 avatar Feb 04 '25 12:02 chemelli74

Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 04 '25 12:02 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 04 '25 18:02 home-assistant[bot]

Coding completed and tested in all variations I was able to. Will add tests once the Team agree on the approach.

chemelli74 avatar Feb 05 '25 12:02 chemelli74

👋 @chemelli74

Any reason this PR is lingering around in draft status?

../Frenck

frenck avatar Mar 02 '25 20:03 frenck

👋 @chemelli74

Any reason this PR is lingering around in draft status?

../Frenck

Just updated code and tests, not sure it's in a good shape. If you have time for a review, is more than appreciated ;-)

Simone

chemelli74 avatar Mar 02 '25 21:03 chemelli74