core
core copied to clipboard
Notify: Deprecated (?) and incomplete "Send a persistent notification" action
The problem
When you select the "Notifications: Send a persistent notification action" in the UI you get this dialog:
defined here:
https://github.com/home-assistant/core/blob/51d694884830cf16d98a749fba8066ee7bed0435/homeassistant/components/notify/strings.json#L45-L61
This somehow is an incomplete copy of the correct dialog for the "Persistent Notification: Create"
that is defined and announced by the Persistent Notification integration:
https://github.com/home-assistant/core/blob/51d694884830cf16d98a749fba8066ee7bed0435/homeassistant/components/persistent_notification/strings.json#L3-L21
Unless there is anything I've overlooked the first one should be deprecated.
Otherwise at least that "data" field should be replaced with the proper name and description from the other definition.
What version of Home Assistant Core has the issue?
2024.11.0b7
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Notify
Link to integration documentation on our website
https://www.home-assistant.io/integrations/notify/
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (notify) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of notify can trigger bot actions by commenting:
@home-assistant closeCloses the issue.@home-assistant rename Awesome new titleRenames the issue.@home-assistant reopenReopen the issue.@home-assistant unassign notifyRemoves the current integration label and assignees on the issue, add the integration domain after the command.@home-assistant add-label needs-more-informationAdd a label (needs-more-information, problem in dependency, problem in custom component) to the issue.@home-assistant remove-label needs-more-informationRemove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.
(message by CodeOwnersMention)
notify documentation notify source (message by IssueLinks)
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.
This is still an issue.
These are two different service actions that use the same target function in the end. We haven't decided to deprecate the notify persistent action as far as I'm aware.
We can clarify the data parameter in the service description and translation. It should hold an object with the notification id of the persistent notification.
Thanks for addressing the issue. I just stumbled over this while translating and wondered why have these duplicates.
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.
Keep alive
There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.