core icon indicating copy to clipboard operation
core copied to clipboard

Add support for Shelly BLU TRV

Open chemelli74 opened this issue 1 year ago • 1 comments

Breaking change

Proposed change

Add support for new device: Shelly BLU TRV

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

chemelli74 avatar Oct 15 '24 10:10 chemelli74

Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Oct 15 '24 10:10 home-assistant[bot]

@chemelli74 Is this still in progress? Because PR is marked as Draft.

leptoquark1 avatar Oct 31 '24 09:10 leptoquark1

@chemelli74 Is this still in progress? Because PR is marked as Draft.

Hi @leptoquark1 yes it's in progress. But we need some firmware changes from Shelly and we are waiting for them.

chemelli74 avatar Oct 31 '24 09:10 chemelli74

Can you link this PR with the relevant Issue or PR?

leptoquark1 avatar Oct 31 '24 09:10 leptoquark1

Can you link this PR with the relevant Issue or PR?

?

chemelli74 avatar Oct 31 '24 10:10 chemelli74

Can you link this PR with the relevant Issue or PR?

?

Sorry I misread your answer, thinking you ment any hass core changes.

However, is there a thread or something of whats missing, further steps and/or issues of involved parties?

I think the currently missing api-docs of the new products would help here, where the available RPC methods are exposed in detail.


There is a workaround with RPC via MQTT or rest-command to extend, for example, the compatibility with other external temperature sensors, but the BLE Gen3 ones.

leptoquark1 avatar Nov 18 '24 09:11 leptoquark1

Can you link this PR with the relevant Issue or PR?

I think this is a good place to discuss support for BLU TRV, not this PR https://community.home-assistant.io/t/new-shelly-trv-blu-integration/777837

bieniu avatar Nov 18 '24 09:11 bieniu

Can you link this PR with the relevant Issue or PR?

I think this is a good place to discuss support for BLU TRV, not this PR https://community.home-assistant.io/t/new-shelly-trv-blu-integration/777837

I'm not sure if the community forum is the right spot for technical discussions. It is, unlike this PR, not linked to the code changes.

I asked about details of the firmware restrictions that block this PR. For any possible contributors its not accessible just by this PR and therefore not clear why the PR seems stale.

However. I assume that it was not possible to control the valve position using the public API. That looks patched in v1.1.1 and is now documented here:

https://shelly-api-docs.shelly.cloud/docs-ble/Devices/trv/

leptoquark1 avatar Dec 08 '24 19:12 leptoquark1

Using suggesting naming approach, the entity is fixed at "climate.shelly_blu_trv". It doesn't take into account the device name. Also if there are more than one, there is just a index ( "_2" ) to differenziate them.

chemelli74 avatar Dec 23 '24 13:12 chemelli74

Using suggesting naming approach, the entity is fixed at "climate.shelly_blu_trv". It doesn't take into account the device name. Also if there are more than one, there is just a index ( "_2" ) to differenziate them.

I don't experience the problem you described above. Can you elaborate? The entity name match the device name, is not fixed for me and would update correctly when changing the name of the device

thecode avatar Dec 23 '24 13:12 thecode