core icon indicating copy to clipboard operation
core copied to clipboard

UniFi Protect Integration: Duplicated "to" in description string

Open NoRi2909 opened this issue 1 year ago • 1 comments

The problem

In the string

 component::unifiprotect::services::set_chime_paired_doorbells::fields::device_id::description

the word "to" is duplicated so it's completely unclear which direction this is meant to work:

"The chimes to link to the doorbells to."

Either:

"The chimes to link to the doorbells."

or

"The chimes to link the doorbells to."

Judging from the description in

  component::unifiprotect::services::set_chime_paired_doorbells::description

"Use to set the paired doorbell(s) with a smart chime."

that plural in "chimes" is also wrong, so this should probably be

"The chime to link to the doorbells."

What version of Home Assistant Core has the issue?

core-2024.10.2

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Unifi Protect

Link to integration documentation on our website

https://www.home-assistant.io/integrations/unifiprotect/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

NoRi2909 avatar Oct 13 '24 08:10 NoRi2909

No comments? - This is a rather simple bug and fix …

NoRi2909 avatar Oct 28 '24 12:10 NoRi2909

Hey @NoRi2909 , greetings from the Westerwald!

I've created a pull request for this #131009. Regarding the plural, as far as I can see, you can have multiple doorbells and multiple chimes, and combine them in all sorts of ways. However, since I can't test this, I'd suggest leaving it as is for now and just removing the definitely unnecessary "to" for the moment.

RaHehl avatar Nov 20 '24 06:11 RaHehl